From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] igb_uio: use existing PCI macros
Date: Fri, 11 Sep 2015 10:10:57 +0200
Message-ID: <2640256.iR0jT46UN8@xps13>
References: <1441900908-29763-1-git-send-email-ferruh.yigit@intel.com>
 <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
 <20150910193300.GA32153@sivlogin002.ir.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 5A18B9E5
 for <dev@dpdk.org>; Fri, 11 Sep 2015 10:12:06 +0200 (CEST)
Received: by wicgb1 with SMTP id gb1so52638270wic.1
 for <dev@dpdk.org>; Fri, 11 Sep 2015 01:12:06 -0700 (PDT)
In-Reply-To: <20150910193300.GA32153@sivlogin002.ir.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-09-10 20:33, Ferruh Yigit:
> > On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> > wrote:
> > 
> > > To get pci_dev and vf number from dev, benefit from
> > > existing macros in pci.h
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Correct me if I am wrong but you might need to provide wrappers for kernel
> > version <= 2.6.34 (or something that indicates availability of those).
> 
> Correct, those macros available after kernel version >= 2.6.34.
> If these is any chance that one using older kernel than this version,
> instead of having wrappers I am for keeping existing implementation and
> drop this patch.

Why should we support kernel older than 2.6.34?
Do we need to update doc/guides/rel_notes/supported_os.rst?