From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Fernando Seiti Furusato <ferseiti@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] build: set CFLAGS for ppc64el build
Date: Tue, 16 Feb 2016 19:09:22 +0100 [thread overview]
Message-ID: <2641339.7y4mNALekD@xps13> (raw)
In-Reply-To: <56C364A4.3010000@linux.vnet.ibm.com>
2016-02-16 16:04, Fernando Seiti Furusato:
> Hi Thomas.
>
> On 02/12/2016 05:18 PM, Fernando Seiti Furusato wrote:
> > Hello Thomas.
> > Thanks for your quick response.
> >
> > On 02/12/2016 03:37 PM, Thomas Monjalon wrote:
> >> 2016-02-12 12:05, Fernando Seiti Furusato:
> >>> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as
> >>> the only one originally set is not valid for ppc architectures.
> >>
> >> What is the benefit of using the default machine config, compared to
> >> the power8 one?
> >>
> >> Don't you think the default machine should be renamed core2?
> >
> > I think it would be better indeed. Thanks for pointing that out.
> >
> >>
> >> [...]
> >>> +ifeq (ppc64le,$(shell uname -m))
> >>> + MACHINE_CFLAGS += -mcpu=power8
> >>
> >> Why this flag is not set in mk/machine/power8/rte.vars.mk ?
> >>
> >
> > This and what observed above would make a better patch.
> > Let me try those.
>
> I will be just changing the flag within mk/machine/power8/rte.vars.mk so
> it will be used on ppc64le.
Does it mean that only little endian is supported on POWER8?
> I thought since I am not sure how it will affect others, I will not mess
> with the default file.
Yes let's keep it for another patch if someone is concerned.
> I had to copy config/defconfig_ppc_64-power8-linuxapp-gcc to
> config/defconfig_ppc64le-native-linuxapp-gcc, because the build searches
> for it on ppc64le. Should I include that in the patch?
> Do you think there is a better approach?
Not sure to understand.
I think there is something wrong in the commands you use to compile.
Are you using "make config T=ppc_64-power8-linuxapp-gcc" ?
next prev parent reply other threads:[~2016-02-16 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:05 [PATCH] build: set CFLAGS for ppc64el build Fernando Seiti Furusato
2016-02-12 17:37 ` Thomas Monjalon
2016-02-12 19:18 ` Fernando Seiti Furusato
2016-02-16 18:04 ` Fernando Seiti Furusato
2016-02-16 18:09 ` Thomas Monjalon [this message]
2016-02-16 19:07 ` Fernando Seiti Furusato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2641339.7y4mNALekD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferseiti@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.