From: David Howells <dhowells@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dhowells@redhat.com, linux-serial@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix an uninitialised variable warning in the 8250 driver
Date: Fri, 14 Nov 2008 16:51:08 +0000 [thread overview]
Message-ID: <26417.1226681468@redhat.com> (raw)
In-Reply-To: <20081114163428.7b676742@lxorguk.ukuu.org.uk>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Current versions of gcc that I've tested get this all correct just fine
> for x86 at least.
gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)
> Do check that the BUG_ON() helper for whatever platform you are using
> needs to correctly indicate that its BUG spewing path may not return
> (__attibute((__noreturn__)). I seem to remember some of the architectures
> are broken on that.
x86_64 - which doesn't do that. It uses asm volatile and an infinite for-loop.
Surely having BUG() retreat through a noreturn function may lose important
state, such as the function that issued the bug as the compiler is under no
requirement to save the return value, and the file/line info may not be
available.
David
next prev parent reply other threads:[~2008-11-14 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 16:20 [PATCH] Fix an uninitialised variable warning in the 8250 driver David Howells
2008-11-14 16:34 ` Alan Cox
2008-11-14 16:34 ` Alan Cox
2008-11-14 16:51 ` David Howells [this message]
2008-11-14 19:01 ` Alan Cox
2008-11-14 19:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26417.1226681468@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.