All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org
Cc: dev-VfR2kkLFssw@public.gmane.org,
	Stephen Hemminger
	<shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] mk: allow application to override clean
Date: Thu, 29 Jan 2015 11:52:01 +0100	[thread overview]
Message-ID: <2643675.CbzNhuDmeJ@xps13> (raw)
In-Reply-To: <54C8C15B.7020407-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Hi Stephen,

2015-01-28 12:00, Olivier MATZ:
> Hi Stephen,
> 
> On 01/23/2015 07:19 AM, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org wrote:
> > From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
> >
> > In some cases application may want to have additional rules
> > for clean. This can be handled by allowing the double colon
> > form of rule.
> >
> >   https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
> 
> There is already a way to do that in dpdk makefiles: you can add
> the following code in your application Makefile, before the line
> that includes $(RTE_SDK)/mk/rte.app.mk:
> 
> POSTCLEAN += my_clean
> 
> .PHONY: my_clean
> my_clean:
> 	@echo executed after clean

Does it fit with your needs?
Should we revert your patch? Double-colon rules were avoided in DPDK.
"Double-colon rules are somewhat obscure and not often very useful"

-- 
Thomas

  parent reply	other threads:[~2015-01-29 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  6:19 [PATCH] mk: allow application to override clean stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ
     [not found] ` <1421993948-24785-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-01-27 11:58   ` Thomas Monjalon
2015-01-28 11:00   ` Olivier MATZ
     [not found]     ` <54C8C15B.7020407-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-01-29 10:52       ` Thomas Monjalon [this message]
2015-01-29 17:07         ` Mcnamara, John
     [not found] ` <1902752B0C92F943AB7EA9EE13E2DEEC287AE6B39E@HQ1-EXCH02.corp.brocade.com>
     [not found]   ` <20150129223641.75306372@uryu.home.lan>
     [not found]     ` <20150129223641.75306372-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
2015-01-30 10:46       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2643675.CbzNhuDmeJ@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
    --cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.