From: Thomas Monjalon <thomas@monjalon.net>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: dev@dpdk.org, Khoa To <khot@microsoft.com>, talshn@nvidia.com
Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH v2] windows: minor build fixes
Date: Fri, 13 Nov 2020 15:16:59 +0100 [thread overview]
Message-ID: <2644481.PlByPBzL6Y@thomas> (raw)
In-Reply-To: <BY5PR21MB13807F6F1858197558E69FD5D9ED0@BY5PR21MB1380.namprd21.prod.outlook.com>
> > Meson versions >= 0.54.0 include support for handling /implib
> > with msvc link. Specifying it explicitly causes failures when
> > linking against the dll. Tested using Link 14.27.29112.0 and
> > Clang 11.0.0.
> >
> > There were a number of changes to the way that import libraries
> > are handled between 0.47.1 and 0.54.0. Only make the change
> > for >= 0.54.0, leaving the behaviour unchanged for earlier
> > versions.
> >
> > Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> > Tested-by: Ranjit Menon <ranjit.menon@intel.com>
> > Acked-by: Ranjit Menon <ranjit.menon@intel.com>
> > ---
> > v2:
> > * split out config/meson.build change
>
> Acked-by: Khoa To <khot@microsoft.com>
Applied, thanks
prev parent reply other threads:[~2020-11-13 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 17:46 [dpdk-dev] [PATCH] Windows: minor build fixes Nick Connolly
2020-10-30 17:46 ` [dpdk-dev] [PATCH] windows: " Nick Connolly
2020-10-30 19:57 ` John Alexander
2020-10-30 20:21 ` Nick Connolly
2020-10-30 21:41 ` Ranjit Menon
2020-10-30 22:51 ` Tal Shnaiderman
2020-10-31 6:16 ` Nick Connolly
2020-10-31 6:44 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-11-06 18:51 ` [dpdk-dev] [EXTERNAL] " Khoa To
2020-11-13 14:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2644481.PlByPBzL6Y@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=khot@microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.