From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@nvidia.com>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release
Date: Wed, 29 Sep 2021 22:46:26 +0200 [thread overview]
Message-ID: <2644582.ixtJruUp4O@thomas> (raw)
In-Reply-To: <DM4PR12MB5389F579747F61760C959CD3DFA99@DM4PR12MB5389.namprd12.prod.outlook.com>
29/09/2021 09:55, Matan Azrad:
> From: Bing Zhao
> > In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> > a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> > once there is a error occurring after the mlx5_alloc_shared_dr(), the
> > mlx5_os_free_shared_dr() is called to release all the resources.
> >
> > To prevent a double release, the pointers of the resources should be
> > checked before the releasing and set to NULL after done.
> >
> > In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> > missed to set to NULL and a double release may cause a crash.
> >
> > By setting the tables pointer to NULL as done for other resources, the double
> > release and crash could be solved.
> >
> > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> > Cc: matan@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied in next-net-mlx, thanks.
prev parent reply other threads:[~2021-09-29 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 4:08 [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release Bing Zhao
2021-09-29 7:55 ` Matan Azrad
2021-09-29 20:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2644582.ixtJruUp4O@thomas \
--to=thomas@monjalon.net \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.