diff for duplicates of <264501dc18dc$39afb340$ad0f19c0$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 8282627..8c6f099 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -57,30 +57,37 @@ Hi Krzysztof > > Do we have any guideline for the same? > > Could you please help with an example from previous any commit or some > other patches? -> > I understand that mentioning, “two clocks, two supplies etc" are part\r -> > of schema, one may or may not capture that in the commit.\r -> > However mentioning, “this hardware (SoC) contain a combo PHY which\r -> supports usb3.1 and usb3.0" is not ok?\r -> \r -> \r -> Maybe that's just language, but to me the commit msg did not describe\r -> hardware after first sentence, but said what schema requires (some\r -> clocks and supplies). Other examples:\r -> 00399bbe02d2bb6fd8d6eb90573ec305616449f4\r -> e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\r -> \r -Thanks for suggestion as always, I hope the author can follow this. \r -\r -> and here another anti-pattern:\r -> 23f793850e9ee7390584c0809f085d6c88de7d3f\r -> \r -> (and before you ask why above carries my Rb tag, then note that\r -I will not ask :-)\r -> Samsung's revenue is around 220 billion USD, so for sure it has a lot,\r -> really a lot of resources to review patches internally and improve their\r -> quality before posting).\r -> \r -Hmm..., however let me check internally.\r -\r -> Best regards,\r +> > I understand that mentioning, “two clocks, two supplies etc" are part +> > of schema, one may or may not capture that in the commit. +> > However mentioning, “this hardware (SoC) contain a combo PHY which +> supports usb3.1 and usb3.0" is not ok? +> +> +> Maybe that's just language, but to me the commit msg did not describe +> hardware after first sentence, but said what schema requires (some +> clocks and supplies). Other examples: +> 00399bbe02d2bb6fd8d6eb90573ec305616449f4 +> e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb +> +Thanks for suggestion as always, I hope the author can follow this. + +> and here another anti-pattern: +> 23f793850e9ee7390584c0809f085d6c88de7d3f +> +> (and before you ask why above carries my Rb tag, then note that +I will not ask :-) +> Samsung's revenue is around 220 billion USD, so for sure it has a lot, +> really a lot of resources to review patches internally and improve their +> quality before posting). +> +Hmm..., however let me check internally. + +> Best regards, > Krzysztof + + + +-- +linux-phy mailing list +linux-phy@lists.infradead.org +https://lists.infradead.org/mailman/listinfo/linux-phy diff --git a/a/content_digest b/N1/content_digest index b8c5395..3984b68 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -97,32 +97,39 @@ "> > Do we have any guideline for the same?\n" "> > Could you please help with an example from previous any commit or some\n" "> other patches?\n" - "> > I understand that mentioning, \342\200\234two clocks, two supplies etc\" are part\r\n" - "> > of schema, one may or may not capture that in the commit.\r\n" - "> > However mentioning, \342\200\234this hardware (SoC) contain a combo PHY which\r\n" - "> supports usb3.1 and usb3.0\" is not ok?\r\n" - "> \r\n" - "> \r\n" - "> Maybe that's just language, but to me the commit msg did not describe\r\n" - "> hardware after first sentence, but said what schema requires (some\r\n" - "> clocks and supplies). Other examples:\r\n" - "> 00399bbe02d2bb6fd8d6eb90573ec305616449f4\r\n" - "> e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\r\n" - "> \r\n" - "Thanks for suggestion as always, I hope the author can follow this. \r\n" - "\r\n" - "> and here another anti-pattern:\r\n" - "> 23f793850e9ee7390584c0809f085d6c88de7d3f\r\n" - "> \r\n" - "> (and before you ask why above carries my Rb tag, then note that\r\n" - "I will not ask :-)\r\n" - "> Samsung's revenue is around 220 billion USD, so for sure it has a lot,\r\n" - "> really a lot of resources to review patches internally and improve their\r\n" - "> quality before posting).\r\n" - "> \r\n" - "Hmm..., however let me check internally.\r\n" - "\r\n" - "> Best regards,\r\n" - > Krzysztof + "> > I understand that mentioning, \342\200\234two clocks, two supplies etc\" are part\n" + "> > of schema, one may or may not capture that in the commit.\n" + "> > However mentioning, \342\200\234this hardware (SoC) contain a combo PHY which\n" + "> supports usb3.1 and usb3.0\" is not ok?\n" + "> \n" + "> \n" + "> Maybe that's just language, but to me the commit msg did not describe\n" + "> hardware after first sentence, but said what schema requires (some\n" + "> clocks and supplies). Other examples:\n" + "> 00399bbe02d2bb6fd8d6eb90573ec305616449f4\n" + "> e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb\n" + "> \n" + "Thanks for suggestion as always, I hope the author can follow this. \n" + "\n" + "> and here another anti-pattern:\n" + "> 23f793850e9ee7390584c0809f085d6c88de7d3f\n" + "> \n" + "> (and before you ask why above carries my Rb tag, then note that\n" + "I will not ask :-)\n" + "> Samsung's revenue is around 220 billion USD, so for sure it has a lot,\n" + "> really a lot of resources to review patches internally and improve their\n" + "> quality before posting).\n" + "> \n" + "Hmm..., however let me check internally.\n" + "\n" + "> Best regards,\n" + "> Krzysztof\n" + "\n" + "\n" + "\n" + "-- \n" + "linux-phy mailing list\n" + "linux-phy@lists.infradead.org\n" + https://lists.infradead.org/mailman/listinfo/linux-phy -a5a90650aec88f46a32bf80ac4edc559766aa8faf17dea62f241b5c30d767124 +4eb00721b0e712fc10a462f00857f0b2a95ef697ac3275561e03167dad001a6c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.