From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Jacopo Mondi Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, peda@axentia.se, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 15:02:59 +0300 Message-ID: <2645564.GDIDDgbfar@avalon> In-Reply-To: <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> References: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:03 EEST Jacopo Mondi wrote: > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > modes, selectable by means of an external pin. > > Describe the LVDS mode map through a newly defined mandatory property in > device tree bindings. > > Signed-off-by: Jacopo Mondi > --- > .../devicetree/bindings/display/bridge/thine,thc63lvd1024.txt | 3 > +++ 1 file changed, 3 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > index 37f0c04..0937595 100644 > --- > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > +++ > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -12,6 +12,8 @@ Required properties: > - compatible: Shall be "thine,thc63lvd1024" > - vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > PPL and digital circuitry > +- thine,map: LVDS mapping mode selection signal, pin name "MAP". Shall be > <1> > + for mapping mode 1, <0> for mapping mode 2 That's sounds like an odd mapping. I suppose you have modeled it based on the state of the MAP pin instead of the mode number (MAP low means mode 2, MAP high means mode 1). To avoid confusing readers I would write it as - thine,map: level of the MAP pin that selects the LVDS mapping mode. Shall be <0> for low level (mapping mode 2) or <1> for high level (mapping mode 1). Apart from that this patch looks good to me. Reviewed-by: Laurent Pinchart > Optional properties: > - powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > @@ -36,6 +38,7 @@ Example: > > vcc-supply = <®_lvds_vcc>; > powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > + thine,map = <1>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 15:02:59 +0300 Message-ID: <2645564.GDIDDgbfar@avalon> References: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, peda@axentia.se, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMTkgQXBy aWwgMjAxOCAxMjozMTowMyBFRVNUIEphY29wbyBNb25kaSB3cm90ZToKPiBUaGUgVEhDNjNMVkQx MDI0IExWRFMgdG8gUkdCIGJyaWRnZSBzdXBwb3J0cyB0d28gZGlmZmVyZW50IGlucHV0IG1hcHBp bmcKPiBtb2Rlcywgc2VsZWN0YWJsZSBieSBtZWFucyBvZiBhbiBleHRlcm5hbCBwaW4uCj4gCj4g RGVzY3JpYmUgdGhlIExWRFMgbW9kZSBtYXAgdGhyb3VnaCBhIG5ld2x5IGRlZmluZWQgbWFuZGF0 b3J5IHByb3BlcnR5IGluCj4gZGV2aWNlIHRyZWUgYmluZGluZ3MuCj4gCj4gU2lnbmVkLW9mZi1i eTogSmFjb3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNhc0BqbW9uZGkub3JnPgo+IC0tLQo+ICAuLi4v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0 ICAgICAgICAgIHwgMwo+ICsrKyAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gCj4g ZGlmZiAtLWdpdAo+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkv YnJpZGdlL3RoaW5lLHRoYzYzbHZkMTAyNC50eHQKPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0Cj4gaW5kZXgg MzdmMGMwNC4uMDkzNzU5NSAxMDA2NDQKPiAtLS0KPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0Cj4gKysrCj4g Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUs dGhjNjNsdmQxMDI0LnR4dAo+IEBAIC0xMiw2ICsxMiw4IEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6 Cj4gIC0gY29tcGF0aWJsZTogU2hhbGwgYmUgInRoaW5lLHRoYzYzbHZkMTAyNCIKPiAgLSB2Y2Mt c3VwcGx5OiBQb3dlciBzdXBwbHkgZm9yIFRUTCBvdXRwdXQsIFRUTCBDTE9DS09VVCBzaWduYWws IExWRFMgaW5wdXQsCj4gUFBMIGFuZCBkaWdpdGFsIGNpcmN1aXRyeQo+ICstIHRoaW5lLG1hcDog TFZEUyBtYXBwaW5nIG1vZGUgc2VsZWN0aW9uIHNpZ25hbCwgcGluIG5hbWUgIk1BUCIuIFNoYWxs IGJlCj4gPDE+Cj4gKyAgZm9yIG1hcHBpbmcgbW9kZSAxLCA8MD4gZm9yIG1hcHBpbmcgbW9kZSAy CgpUaGF0J3Mgc291bmRzIGxpa2UgYW4gb2RkIG1hcHBpbmcuIEkgc3VwcG9zZSB5b3UgaGF2ZSBt b2RlbGVkIGl0IGJhc2VkIG9uIHRoZSAKc3RhdGUgb2YgdGhlIE1BUCBwaW4gaW5zdGVhZCBvZiB0 aGUgbW9kZSBudW1iZXIgKE1BUCBsb3cgbWVhbnMgbW9kZSAyLCBNQVAgCmhpZ2ggbWVhbnMgbW9k ZSAxKS4gVG8gYXZvaWQgY29uZnVzaW5nIHJlYWRlcnMgSSB3b3VsZCB3cml0ZSBpdCBhcwoKLSB0 aGluZSxtYXA6IGxldmVsIG9mIHRoZSBNQVAgcGluIHRoYXQgc2VsZWN0cyB0aGUgTFZEUyBtYXBw aW5nIG1vZGUuIFNoYWxsIGJlCiAgPDA+IGZvciBsb3cgbGV2ZWwgKG1hcHBpbmcgbW9kZSAyKSBv ciA8MT4gZm9yIGhpZ2ggbGV2ZWwgKG1hcHBpbmcgbW9kZSAxKS4KCkFwYXJ0IGZyb20gdGhhdCB0 aGlzIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuCgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAgT3B0aW9uYWwgcHJvcGVy dGllczoKPiAgLSBwb3dlcmRvd24tZ3Bpb3M6IFBvd2VyIGRvd24gR1BJTyBzaWduYWwsIHBpbiBu YW1lICIvUERXTiIuIEFjdGl2ZSBsb3cKPiBAQCAtMzYsNiArMzgsNyBAQCBFeGFtcGxlOgo+IAo+ ICAJCXZjYy1zdXBwbHkgPSA8JnJlZ19sdmRzX3ZjYz47Cj4gIAkJcG93ZXJkb3duLWdwaW9zID0g PCZncGlvNCAxNSBHUElPX0FDVElWRV9MT1c+Owo+ICsJCXRoaW5lLG1hcCA9IDwxPjsKPiAKPiAg CQlwb3J0cyB7Cj4gIAkJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoKLS0gClJlZ2FyZHMsCgpMYXVy ZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=