From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJ9ts-0004HS-PC for mharc-grub-devel@gnu.org; Thu, 26 Aug 2021 03:34:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJ9tr-0004HJ-7c for grub-devel@gnu.org; Thu, 26 Aug 2021 03:34:11 -0400 Received: from mout.gmx.net ([212.227.15.18]:52843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJ9to-0008Ly-Pa for grub-devel@gnu.org; Thu, 26 Aug 2021 03:34:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629963246; bh=dMhoZTwPOKN5/AKNQF0qhhJa/UfBQxz+pEZMKMeQSNE=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=W8Vz7izp9iGZEbvDG9kQWtp2cF5dQqyMx+d1rFyBUmQji6tslNQA2j+ozoFAHw95U I2I9hl/ov2NofoM7uzVpG6JXzXRTs5/eCqNgeLjPJ4AAs+iyxGQ7ZDXxrbc4zAHytR GxuS4GBB0OgnWfeAK+Fv1MkgjFK0JcQFZSEAx7R8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.233.243]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhlGk-1mwuVC2umW-00dlzq for ; Thu, 26 Aug 2021 09:34:06 +0200 Date: Thu, 26 Aug 2021 09:34:52 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [grub-fs-tester.in] zisofs test looks unsuitable Content-Type: text/plain; charset="utf-8" Cc: development@efficientek.com References: <20210825155923.567a411d@crass-HP-ZBook-15-G2> In-Reply-To: <20210825155923.567a411d@crass-HP-ZBook-15-G2> Message-Id: <26478360869664256672@scdbackup.webframe.org> X-Provags-ID: V03:K1:mL1ycbJYIhvqbO2JOc1O9119t8NqZEYjsVzmZj3/9D/EOxqWcV6 ijy4rnlwOBpeh6XgjqIsxZKhbcNKto3gBzhb6Hv8fzGRD2Bxz0UUUY4zabvyw7k8SSMQ9bZ e6xTo2EcYuzJaO1lOu0siFus/+y/pcCMTVRdz7+fczEKHQ5s8uuPNgryawUJSLZvOgK3Z5c OdqonZB9m7XZgKMp8+k1g== X-UI-Out-Filterresults: notjunk:1;V03:K0:Uo6H5Qlw1vU=:u1tsQ+G+mZWXE4zvG82ImF eUJb2dZhsO+MHlkCOFe61cZuDKjSAdCRw2W8rjoXq+zFMgGs+v9rXxlnRUsodZXYi0+c6qjWk 6xrWNcPfTEkWIipjMiBgpit7HtIy74YG2ptpBHQVtRzOqtMjCsWF7cWrSkaUK9WtDxjhH/sUK mxKLifzxpOfcMYTAOfx6b5Sdz//TabSojCQU05rFMfH0hN8frYnzE0ViTeBcewISL1j/mN95x xlnKEdNUZyVnUBeDKhqi0M+PBrXhh0EHKf39Z5rV3DVSDhrjLlkp/dcAQIl/lSMWiIa8fHu0f UAiWmSY/pKHcv2B7HiTD/plcs/hCmk7MIT1W4btD/UN+31Qdhia+Gg1PCGvtPbXFPDt37Uaqf I3TmwjN2qY1T4wRnV0m2ol+7TSLyjKUFSRS5MWMde2uk25HzaPf0GcFMM5ojsG1/Yhh/qUgtI BUedk06dQpxwTjYkrU4fcG7v6khZzfnFq2Vpr5GMftStBTL79yOM7A+AQHG+4fkv7cmLLXxAj JpdxVIFKO6y6irZinWzes9tpJLYpkG7yPCmrx/vuxzHrFA2P3Vs31vskqSA3GS4530gNMnilO jJTGVcFRamgmVGWlcwne5l4fp4h9CTLaBxCdyVbpNcw6TgzdApaBkuZ0iJ6Iv0LhGsiQHpAnC mFMPVX02tdPu3dpqBqVjNywoQWddbGNS3qJ0gruUbQ48fCfmlJRuyQbTS/i20r/YW69Mip4s2 cdf6T6BLsC+y2+uJoXvtGtS5H+DWpYkF3KirgTmd3ytjcrP6BTFMaCZRKWIzrX7HTKNmxn8oT 1jwOzSScd9bu57/ZBLP4pCd3EnPd2szf9+GFRW1sIzCyBN0il/BmUte06HHvm5lrKuI5ElJ6B Q73ud2RfoW00vrSQGaHgs4q8nqv7S+6HJ5a76V5LahMRiaO4IDTo7CMb2R9MYlIBRxP43myoL l23kxw3vRpBG6W83t4/vszmF/4uxJF85CbLcwKf5Zf7NWbYG/2TzDpXQ1pm2Afn0NOgP/UmTP GSJBXj/r2r+htuye/R4/LPsbQkI43SnxNKE+qsSKTeqjZEENRVMI6Syz2prKWsaIKXNodFPeA 2RGKK+FK8BrpkFZAtn4xV7kT4zzGtlVLpXeIeqRZrqlRG4SpGdOSWIo1w== Received-SPF: pass client-ip=212.227.15.18; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 07:34:11 -0000 Hi, Glenn Washburn wrote: > If I'm not mistaken, there is currently no test which actually > exercises that code, ie no test runs "grub-fs-tester ziso9660". I think > it could be a good idea to have one though. So we should get this to work. zisofs can be helpful to squeeze more operating system into a size limited ISO image. > However, when attempting to run the test manually, I'm getting a > failure probably related to what you've found. > $ ./grub-fs-tester ziso9660 > [...] > xorriso : FAILURE : -volid: Text too long (1650 > 32) This is something different. "-volid" is the native xorriso command that's behind mkisofs emulation option -V. In https://git.savannah.gnu.org/cgit/grub.git/tree/tests/util/grub-fs-tester.in#n1024 i see -V "$FSLABEL" which is also used with the case x"iso9660"). So i assume that it is not curbed to 32 bytes by the code after line 315 # FS LIMITATION: afs and iso9660 label is at most 32 UTF-8 characters It seems that line 317 should be extended by a new line 318 - | xiso9660_1999 | xrockridge_1999 | xrockridge_joliet_1999) + | xiso9660_1999 | xrockridge_1999 | xrockridge_joliet_1999\ + | xziso9660) Nitpicking: The comment speaks of "32 UTF-8 characters" but it must be at most 32 bytes. (Wisely the code does not truncate the long UTF-8 string but rather creates a new string, which seems to have 31 bytes. I'm unsure whether my desktop properly copies and pastes those [02F 99x] characters from line 318.) Have a nice day :) Thomas