From: David Woodhouse <dwmw2@infradead.org>
To: Dawson Engler <engler@csl.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions
Date: Wed, 30 May 2001 22:33:23 +0100 [thread overview]
Message-ID: <26484.991258403@redhat.com> (raw)
In-Reply-To: <200105302008.NAA07710@csl.Stanford.EDU>
In-Reply-To: <200105302008.NAA07710@csl.Stanford.EDU>
engler@csl.Stanford.EDU said:
> drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn
> 'DoC_Probe' calling init fn 'doccheck'
Strictly speaking, not actually a bug. DoC_Probe() itself is only ever
called from __init code. But it's probably not worth trying to make the
checker notice that situation - I've fixed it anyway by making DoC_Probe()
__init too, which saves a bit more memory. Thanks.
parse_mem_cmdline() in arch/i386/kernel/setup.c is a similar false (or at
least questionable) positive. Note that it's an inline function, only used
inside setup_arch(), which _is_ marked __init.
--
dwmw2
next prev parent reply other threads:[~2001-05-30 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 20:08 [CHECKER] 2.4.5-ac4 non-init functions calling init functions Dawson Engler
2001-05-30 21:33 ` David Woodhouse [this message]
2001-05-30 22:00 ` Oliver Xymoron
2001-05-30 23:01 ` Dawson Engler
2001-05-31 7:09 ` David Woodhouse
2001-05-30 21:40 ` Harald Welte
2001-05-30 23:08 ` [PATCH] " Petr Vandrovec
2001-05-31 21:38 ` Kai Germaschewski
2001-05-31 22:06 ` Dawson Engler
2001-06-01 7:48 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2001-06-01 18:09 Khachaturov, Vassilii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26484.991258403@redhat.com \
--to=dwmw2@infradead.org \
--cc=engler@csl.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.