Re: [PATCH v13 0/7] Introduce perf check subcommand

[Aditya Gupta <adityag@linux.ibm.com>]

Hi Arnaldo,

On 03/09/24 21:00, Arnaldo Carvalho de Melo wrote:
> On Thu, Jul 18, 2024 at 02:29:50PM +0530, Aditya Gupta wrote:
>> The Problem
>> ===========
>>
>> Currently the presence of a feature is checked with a combination of
>> perf version --build-options and greps, such as:
>>
>>      perf version --build-options | grep " on .* HAVE_FEATURE"
>>
>> This relies on the output of perf version, and is a common pattern in tests.
>>
>> Proposed solution
>> =================
>>
>> As suggested by contributors in:
>> https://lore.kernel.org/linux-perf-users/ZMPWk5K63tadmDlU@kernel.org/
>>
>> Introduce a subcommand "perf check feature", with which
>> scripts can test for presence of a feature or multiple features, such as:
> I tried to resume reviewing/testing but:
>
> Total patches: 7
> ---
> Cover: ./v13_20240718_adityag_introduce_perf_check_subcommand.cover
>   Link: https://lore.kernel.org/r/20240718085957.550858-1-adityag@linux.ibm.com
>   Base: not specified
>         git am ./v13_20240718_adityag_introduce_perf_check_subcommand.mbx
> ⬢[acme@toolbox perf-tools-next]$        git am ./v13_20240718_adityag_introduce_perf_check_subcommand.mbx
> Applying: tools/lib/subcmd: Don't free the usage string
> Applying: perf check: Introduce 'check' subcommand
> Applying: perf version: Update --build-options to use 'supported_features' array
> error: patch failed: tools/perf/builtin-version.c:46
> error: tools/perf/builtin-version.c: patch does not apply
> Patch failed at 0003 perf version: Update --build-options to use 'supported_features' array
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config advice.mergeConflict false"
> ⬢[acme@toolbox perf-tools-next]$

Maybe I need to rebase it now. I will rebase and send it again.


Thanks,

Aditya Gupta