From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 09/16] drm/shmobile: removed optional dummy crtc mode_fixup function. Date: Wed, 17 Feb 2016 17:24:21 +0200 Message-ID: <2650605.Mb3ma0pO7s@avalon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Carlos Palminha Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, patrik.r.jakobsson@gmail.com, virtualization@lists.linux-foundation.org, jani.nikula@intel.com, sudipm.mukherjee@gmail.com, nicolas.pitre@linaro.org, linux-renesas-soc@vger.kernel.org, benjamin.gaignard@linaro.org, vincent.abriou@st.com, boris.brezillon@free-electrons.com, kraxel@redhat.com, jianwei.wang.chn@gmail.com, alison.wang@freescale.com List-Id: dri-devel@lists.freedesktop.org Hi Carlos, Thank you for the patch. On Tuesday 16 February 2016 14:18:40 Carlos Palminha wrote: > This patch set nukes all the dummy crtc mode_fixup implementations. > (made on top of Daniel topic/drm-misc branch) > > Signed-off-by: Carlos Palminha Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 27342fd..88643ab 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > @@ -359,13 +359,6 @@ static void shmob_drm_crtc_dpms(struct drm_crtc *crtc, > int mode) scrtc->dpms = mode; > } > > -static bool shmob_drm_crtc_mode_fixup(struct drm_crtc *crtc, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - return true; > -} > - > static void shmob_drm_crtc_mode_prepare(struct drm_crtc *crtc) > { > shmob_drm_crtc_dpms(crtc, DRM_MODE_DPMS_OFF); > @@ -431,7 +424,6 @@ static int shmob_drm_crtc_mode_set_base(struct drm_crtc > *crtc, int x, int y, > > static const struct drm_crtc_helper_funcs crtc_helper_funcs = { > .dpms = shmob_drm_crtc_dpms, > - .mode_fixup = shmob_drm_crtc_mode_fixup, > .prepare = shmob_drm_crtc_mode_prepare, > .commit = shmob_drm_crtc_mode_commit, > .mode_set = shmob_drm_crtc_mode_set, -- Regards, Laurent Pinchart