From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC7Pu-0003yx-Bq for qemu-devel@nongnu.org; Wed, 30 Nov 2016 11:07:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC7Pq-0000yk-8z for qemu-devel@nongnu.org; Wed, 30 Nov 2016 11:07:30 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:44735) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cC7Pq-0000yU-0P for qemu-devel@nongnu.org; Wed, 30 Nov 2016 11:07:26 -0500 Date: Wed, 30 Nov 2016 11:07:22 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <26516885.587872.1480522042966.JavaMail.zimbra@redhat.com> In-Reply-To: <8760n5f05u.fsf@dusky.pond.sub.org> References: <20161117155504.21843-1-marcandre.lureau@redhat.com> <20161117155504.21843-10-marcandre.lureau@redhat.com> <8760n5f05u.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 09/17] qapi: add some sections in docs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org Hi ----- Original Message ----- > Second thoughts... >=20 > Marc-Andr=C3=A9 Lureau writes: >=20 > > Add some more section titles to organize the produced documents. > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > qapi-schema.json | 4 ++++ > > qapi/block-core.json | 6 ++++-- > > qapi/block.json | 10 ++++++++-- > > qapi/common.json | 6 ++++-- > > qapi/crypto.json | 5 ++++- > > qapi/event.json | 6 ++++++ > > qapi/rocker.json | 4 ++++ > > qapi/trace.json | 3 +++ > > 8 files changed, 37 insertions(+), 7 deletions(-) > > > > diff --git a/qapi-schema.json b/qapi-schema.json > > index dfe68ba..69340f2 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -20,6 +20,10 @@ > > # QAPI introspection > > { 'include': 'qapi/introspect.json' } > > =20 > > +## > > +# =3D QMP commands > > +## > > + > > ## > > # @qmp_capabilities: > > # > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index ec1da2a..05cedc3 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -1,6 +1,8 @@ > > # -*- Mode: Python -*- > > -# > > -# QAPI block core definitions (vm unrelated) > > + > > +## > > +# =3D=3D QAPI block core definitions (vm unrelated) > > +## > > =20 > > # QAPI common definitions > > { 'include': 'common.json' } > > diff --git a/qapi/block.json b/qapi/block.json > > index 937df05..e4ad74b 100644 > > --- a/qapi/block.json > > +++ b/qapi/block.json > > @@ -1,10 +1,16 @@ > > # -*- Mode: Python -*- > > -# > > -# QAPI block definitions (vm related) > > + > > +## > > +# =3D QAPI block definitions > > +## > > =20 > > # QAPI block core definitions > > { 'include': 'block-core.json' } > > =20 > > +## > > +# =3D=3D QAPI block definitions (vm unrelated) > > +## > > + > > ## > > # @BiosAtaTranslation: > > # > > diff --git a/qapi/common.json b/qapi/common.json > > index 624a861..d93f159 100644 > > --- a/qapi/common.json > > +++ b/qapi/common.json > > @@ -1,6 +1,8 @@ > > # -*- Mode: Python -*- > > -# > > -# QAPI common definitions > > + > > +## > > +# =3D QAPI common definitions > > +## > > =20 > > ## > > # @QapiErrorClass: > > diff --git a/qapi/crypto.json b/qapi/crypto.json > > index 15d296e..1e517b0 100644 > > --- a/qapi/crypto.json > > +++ b/qapi/crypto.json > > @@ -1,6 +1,9 @@ > > # -*- Mode: Python -*- > > # > > -# QAPI crypto definitions > > + > > +## > > +# =3D QAPI crypto definitions > > +## > > =20 > > ## > > # @QCryptoTLSCredsEndpoint: > > diff --git a/qapi/event.json b/qapi/event.json > > index 37bf34e..59942b0 100644 > > --- a/qapi/event.json > > +++ b/qapi/event.json > > @@ -1,3 +1,9 @@ > > +# -*- Mode: Python -*- > > + > > +## > > +# =3D Events > > +## > > + >=20 > This suggests *all* events are in this section, which isn't the case. > "Other events"? "Core events"? Dunno... "Other events" sounds nice to me. I think we could improve the organization= after.=20 > > ## > > # @SHUTDOWN: > > # > > diff --git a/qapi/rocker.json b/qapi/rocker.json > > index ace2776..dd72e02 100644 > > --- a/qapi/rocker.json > > +++ b/qapi/rocker.json > > @@ -1,4 +1,8 @@ > > ## > > +# =3D Rocker API >=20 > What about "Rocker switch device"? ok >=20 > > +## > > + > > +## > > # @RockerSwitch: > > # > > # Rocker switch information. > > diff --git a/qapi/trace.json b/qapi/trace.json > > index 4fd39b7..3ad7df7 100644 > > --- a/qapi/trace.json > > +++ b/qapi/trace.json > > @@ -5,6 +5,9 @@ > > # This work is licensed under the terms of the GNU GPL, version 2 or > > later. > > # See the COPYING file in the top-level directory. > > =20 > > +## > > +# =3D Tracing commands > > +## > > =20 > > ## > > # @TraceEventState: >=20