From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:46842 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728999AbeJASdT (ORCPT ); Mon, 1 Oct 2018 14:33:19 -0400 From: Laurent Pinchart To: Daniel Vetter Cc: Souptick Joarder , Gustavo Padovan , Maarten Lankhorst , sean@poorly.run, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Noralf =?ISO-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume() Date: Mon, 01 Oct 2018 14:56:06 +0300 Message-ID: <26527911.hs5tlrnKDc@avalon> In-Reply-To: <20181001065220.GE11082@phenom.ffwll.local> References: <20180918163903.GA11172@jordon-HP-15-Notebook-PC> <20809880.gF2CxujBy3@avalon> <20181001065220.GE11082@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Daniel, On Monday, 1 October 2018 09:52:20 EEST Daniel Vetter wrote: > On Fri, Sep 28, 2018 at 06:30:35PM +0300, Laurent Pinchart wrote: > > On Friday, 28 September 2018 18:05:18 EEST Laurent Pinchart wrote: > > > On Thursday, 27 September 2018 09:34:18 EEST Souptick Joarder wrote: > > > > On Tue, Sep 18, 2018 at 10:05 PM Souptick Joarder wrote: > > > >> convert drm_atomic_helper_suspend/resume() to use > > > >> drm_mode_config_helper_suspend/resume(). > > > >>=20 > > > >> remove suspend_state field from the rcar_du_device > > > >> structure as it is no more required. > > > >>=20 > > > >> With this conversion, also drm_fbdev_cma_set_suspend_unlocked() > > > >> will left with no consumer. So this function can be removed. > > > >>=20 > > > >> Signed-off-by: Souptick Joarder > > > >=20 > > > > Laurent, any comment on this patch ?? > > >=20 > > > Sorry for the delay, and thanks for pinging me. > > >=20 > > > Reviewed-by: Laurent Pinchart > > >=20 > > > Should I apply this to my tree or do you plan to merge it through > > > drm-misc > > > as it touches drm_fb_cma_helper.c ? > >=20 > > I just realized that the same patch got supplied by Noralf Tr=F8nnes ne= arly > > a > > year ago, and was later superseded by > > https://patchwork.freedesktop.org/patch/247861/. I think we should thus > > apply Noralf's patches instead (once he sends v4 out). >=20 > I don't think Noralf is still actively working on this, he's busy with the > fbdev emulation stuff. Probably better if you pick up one of the existing > ones, than waiting another year or so :-) Isn't https://patchwork.freedesktop.org/patch/247861/ part of the fbdev=20 emulation stuff ? That patch series is from less than a month ago, so I=20 thought it was actively developed. Let's ask him. Noralf, any comment ? :-)=20 > > > >> --- > > > >>=20 > > > >> drivers/gpu/drm/drm_fb_cma_helper.c | 18 ------------------ > > > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 ++------------------- > > > >> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 - > > > >> include/drm/drm_fb_cma_helper.h | 2 -- > > > >> 4 files changed, 2 insertions(+), 40 deletions(-) > > > >>=20 > > > >> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > > > >> b/drivers/gpu/drm/drm_fb_cma_helper.c index 47e0e2f..96efc88 100644 > > > >> --- a/drivers/gpu/drm/drm_fb_cma_helper.c > > > >> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > > > >> @@ -224,21 +224,3 @@ void drm_fbdev_cma_hotplug_event(struct > > > >> drm_fbdev_cma *fbdev_cma) > > > >>=20 > > > >> drm_fb_helper_hotplug_event(&fbdev_cma->fb_helper); > > > >> =20 > > > >> } > > > >> EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event); > > > >>=20 > > > >> - > > > >> -/** > > > >> - * drm_fbdev_cma_set_suspend_unlocked - wrapper around > > > >> - * > > > >> drm_fb_helper_set_suspend_unlocked > > > >> - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > > > >> - * @state: desired state, zero to resume, non-zero to suspend > > > >> - * > > > >> - * Calls drm_fb_helper_set_suspend, which is a wrapper around > > > >> - * fb_set_suspend implemented by fbdev core. > > > >> - */ > > > >> -void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma > > > >> *fbdev_cma, > > > >> - bool state) > > > >> -{ > > > >> - if (fbdev_cma) > > > >> - > > > >> drm_fb_helper_set_suspend_unlocked(&fbdev_cma->fb_helper, > > > >> - state); > > > >> -} > > > >> -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend_unlocked); > > > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..288220f 100= 644 > > > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > >> @@ -357,32 +357,15 @@ static void rcar_du_lastclose(struct drm_dev= ice > > > >> *dev) > > > >>=20 > > > >> static int rcar_du_pm_suspend(struct device *dev) > > > >> { > > > >> =20 > > > >> struct rcar_du_device *rcdu =3D dev_get_drvdata(dev); > > > >>=20 > > > >> - struct drm_atomic_state *state; > > > >>=20 > > > >> - drm_kms_helper_poll_disable(rcdu->ddev); > > > >> - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, true); > > > >> - > > > >> - state =3D drm_atomic_helper_suspend(rcdu->ddev); > > > >> - if (IS_ERR(state)) { > > > >> - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, > > > >> false); > > > >> - drm_kms_helper_poll_enable(rcdu->ddev); > > > >> - return PTR_ERR(state); > > > >> - } > > > >> - > > > >> - rcdu->suspend_state =3D state; > > > >> - > > > >> - return 0; > > > >> + return drm_mode_config_helper_suspend(rcdu->ddev); > > > >>=20 > > > >> } > > > >> =20 > > > >> static int rcar_du_pm_resume(struct device *dev) > > > >> { > > > >> =20 > > > >> struct rcar_du_device *rcdu =3D dev_get_drvdata(dev); > > > >>=20 > > > >> - drm_atomic_helper_resume(rcdu->ddev, rcdu->suspend_state); > > > >> - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false); > > > >> - drm_kms_helper_poll_enable(rcdu->ddev); > > > >> - > > > >> - return 0; > > > >> + return drm_mode_config_helper_resume(rcdu->ddev); > > > >>=20 > > > >> } > > > >> #endif > > > >>=20 > > > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > > > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.h index b3a25e8..ff25c8d 100= 644 > > > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > > > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > > > >> @@ -78,7 +78,6 @@ struct rcar_du_device { > > > >>=20 > > > >> struct drm_device *ddev; > > > >> struct drm_fbdev_cma *fbdev; > > > >>=20 > > > >> - struct drm_atomic_state *suspend_state; > > > >>=20 > > > >> struct rcar_du_crtc crtcs[RCAR_DU_MAX_CRTCS]; > > > >> unsigned int num_crtcs; > > > >>=20 > > > >> diff --git a/include/drm/drm_fb_cma_helper.h > > > >> b/include/drm/drm_fb_cma_helper.h index 4a65f0d..8dbbe1e 100644 > > > >> --- a/include/drm/drm_fb_cma_helper.h > > > >> +++ b/include/drm/drm_fb_cma_helper.h > > > >> @@ -26,8 +26,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct > > > >> drm_device *dev, > > > >>=20 > > > >> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma); > > > >> void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma); > > > >>=20 > > > >> -void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma > > > >> *fbdev_cma, > > > >> - bool state); > > > >>=20 > > > >> struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct > > > >> drm_framebuffer *fb, > > > >> =20 > > > >> unsigned int plane); =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume() Date: Mon, 01 Oct 2018 14:56:06 +0300 Message-ID: <26527911.hs5tlrnKDc@avalon> References: <20180918163903.GA11172@jordon-HP-15-Notebook-PC> <20809880.gF2CxujBy3@avalon> <20181001065220.GE11082@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0A4789FEC for ; Mon, 1 Oct 2018 11:55:52 +0000 (UTC) In-Reply-To: <20181001065220.GE11082@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Souptick Joarder , sean@poorly.run List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gTW9uZGF5LCAxIE9jdG9iZXIgMjAxOCAwOTo1MjoyMCBFRVNUIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gT24gRnJpLCBTZXAgMjgsIDIwMTggYXQgMDY6MzA6MzVQTSArMDMw MCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IE9uIEZyaWRheSwgMjggU2VwdGVtYmVyIDIw MTggMTg6MDU6MTggRUVTVCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gPiBPbiBUaHVyc2Rh eSwgMjcgU2VwdGVtYmVyIDIwMTggMDk6MzQ6MTggRUVTVCBTb3VwdGljayBKb2FyZGVyIHdyb3Rl Ogo+ID4gPiA+IE9uIFR1ZSwgU2VwIDE4LCAyMDE4IGF0IDEwOjA1IFBNIFNvdXB0aWNrIEpvYXJk ZXIgd3JvdGU6Cj4gPiA+ID4+IGNvbnZlcnQgZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZC9yZXN1 bWUoKSB0byB1c2UKPiA+ID4gPj4gZHJtX21vZGVfY29uZmlnX2hlbHBlcl9zdXNwZW5kL3Jlc3Vt ZSgpLgo+ID4gPiA+PiAKPiA+ID4gPj4gcmVtb3ZlIHN1c3BlbmRfc3RhdGUgZmllbGQgZnJvbSB0 aGUgcmNhcl9kdV9kZXZpY2UKPiA+ID4gPj4gc3RydWN0dXJlIGFzIGl0IGlzIG5vIG1vcmUgcmVx dWlyZWQuCj4gPiA+ID4+IAo+ID4gPiA+PiBXaXRoIHRoaXMgY29udmVyc2lvbiwgYWxzbyBkcm1f ZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2VkKCkKPiA+ID4gPj4gd2lsbCBsZWZ0IHdpdGgg bm8gY29uc3VtZXIuIFNvIHRoaXMgZnVuY3Rpb24gY2FuIGJlIHJlbW92ZWQuCj4gPiA+ID4+IAo+ ID4gPiA+PiBTaWduZWQtb2ZmLWJ5OiBTb3VwdGljayBKb2FyZGVyIDxqcmRyLmxpbnV4QGdtYWls LmNvbT4KPiA+ID4gPiAKPiA+ID4gPiBMYXVyZW50LCBhbnkgY29tbWVudCBvbiB0aGlzIHBhdGNo ID8/Cj4gPiA+IAo+ID4gPiBTb3JyeSBmb3IgdGhlIGRlbGF5LCBhbmQgdGhhbmtzIGZvciBwaW5n aW5nIG1lLgo+ID4gPiAKPiA+ID4gUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiA+ID4gCj4gPiA+IFNob3VsZCBJIGFwcGx5 IHRoaXMgdG8gbXkgdHJlZSBvciBkbyB5b3UgcGxhbiB0byBtZXJnZSBpdCB0aHJvdWdoCj4gPiA+ IGRybS1taXNjCj4gPiA+IGFzIGl0IHRvdWNoZXMgZHJtX2ZiX2NtYV9oZWxwZXIuYyA/Cj4gPiAK PiA+IEkganVzdCByZWFsaXplZCB0aGF0IHRoZSBzYW1lIHBhdGNoIGdvdCBzdXBwbGllZCBieSBO b3JhbGYgVHLDuG5uZXMgbmVhcmx5Cj4gPiBhCj4gPiB5ZWFyIGFnbywgYW5kIHdhcyBsYXRlciBz dXBlcnNlZGVkIGJ5Cj4gPiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gv MjQ3ODYxLy4gSSB0aGluayB3ZSBzaG91bGQgdGh1cwo+ID4gYXBwbHkgTm9yYWxmJ3MgcGF0Y2hl cyBpbnN0ZWFkIChvbmNlIGhlIHNlbmRzIHY0IG91dCkuCj4gCj4gSSBkb24ndCB0aGluayBOb3Jh bGYgaXMgc3RpbGwgYWN0aXZlbHkgd29ya2luZyBvbiB0aGlzLCBoZSdzIGJ1c3kgd2l0aCB0aGUK PiBmYmRldiBlbXVsYXRpb24gc3R1ZmYuIFByb2JhYmx5IGJldHRlciBpZiB5b3UgcGljayB1cCBv bmUgb2YgdGhlIGV4aXN0aW5nCj4gb25lcywgdGhhbiB3YWl0aW5nIGFub3RoZXIgeWVhciBvciBz byA6LSkKCklzbid0IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8yNDc4 NjEvIHBhcnQgb2YgdGhlIGZiZGV2IAplbXVsYXRpb24gc3R1ZmYgPyBUaGF0IHBhdGNoIHNlcmll cyBpcyBmcm9tIGxlc3MgdGhhbiBhIG1vbnRoIGFnbywgc28gSSAKdGhvdWdodCBpdCB3YXMgYWN0 aXZlbHkgZGV2ZWxvcGVkLgoKTGV0J3MgYXNrIGhpbS4gTm9yYWxmLCBhbnkgY29tbWVudCA/IDot KSAKCj4gPiA+ID4+IC0tLQo+ID4gPiA+PiAKPiA+ID4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfY21hX2hlbHBlci5jICAgfCAxOCAtLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4gPj4gIGRyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgfCAyMSArKy0tLS0tLS0tLS0tLS0tLS0t LS0KPiA+ID4gPj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmggfCAgMSAt Cj4gPiA+ID4+ICBpbmNsdWRlL2RybS9kcm1fZmJfY21hX2hlbHBlci5oICAgICAgIHwgIDIgLS0K PiA+ID4gPj4gIDQgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA0MCBkZWxldGlvbnMo LSkKPiA+ID4gPj4gCj4gPiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zi X2NtYV9oZWxwZXIuYwo+ID4gPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBl ci5jIGluZGV4IDQ3ZTBlMmYuLjk2ZWZjODggMTAwNjQ0Cj4gPiA+ID4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gPiA+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZmJfY21hX2hlbHBlci5jCj4gPiA+ID4+IEBAIC0yMjQsMjEgKzIyNCwzIEBAIHZvaWQg ZHJtX2ZiZGV2X2NtYV9ob3RwbHVnX2V2ZW50KHN0cnVjdAo+ID4gPiA+PiBkcm1fZmJkZXZfY21h ICpmYmRldl9jbWEpCj4gPiA+ID4+IAo+ID4gPiA+PiAgICAgICAgICAgICAgICAgZHJtX2ZiX2hl bHBlcl9ob3RwbHVnX2V2ZW50KCZmYmRldl9jbWEtPmZiX2hlbHBlcik7Cj4gPiA+ID4+ICAKPiA+ ID4gPj4gIH0KPiA+ID4gPj4gIEVYUE9SVF9TWU1CT0xfR1BMKGRybV9mYmRldl9jbWFfaG90cGx1 Z19ldmVudCk7Cj4gPiA+ID4+IAo+ID4gPiA+PiAtCj4gPiA+ID4+IC0vKioKPiA+ID4gPj4gLSAq IGRybV9mYmRldl9jbWFfc2V0X3N1c3BlbmRfdW5sb2NrZWQgLSB3cmFwcGVyIGFyb3VuZAo+ID4g PiA+PiAtICoKPiA+ID4gPj4gZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZF91bmxvY2tlZAo+ID4g PiA+PiAtICogQGZiZGV2X2NtYTogVGhlIGRybV9mYmRldl9jbWEgc3RydWN0LCBtYXkgYmUgTlVM TAo+ID4gPiA+PiAtICogQHN0YXRlOiBkZXNpcmVkIHN0YXRlLCB6ZXJvIHRvIHJlc3VtZSwgbm9u LXplcm8gdG8gc3VzcGVuZAo+ID4gPiA+PiAtICoKPiA+ID4gPj4gLSAqIENhbGxzIGRybV9mYl9o ZWxwZXJfc2V0X3N1c3BlbmQsIHdoaWNoIGlzIGEgd3JhcHBlciBhcm91bmQKPiA+ID4gPj4gLSAq IGZiX3NldF9zdXNwZW5kIGltcGxlbWVudGVkIGJ5IGZiZGV2IGNvcmUuCj4gPiA+ID4+IC0gKi8K PiA+ID4gPj4gLXZvaWQgZHJtX2ZiZGV2X2NtYV9zZXRfc3VzcGVuZF91bmxvY2tlZChzdHJ1Y3Qg ZHJtX2ZiZGV2X2NtYQo+ID4gPiA+PiAqZmJkZXZfY21hLAo+ID4gPiA+PiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBzdGF0ZSkKPiA+ID4gPj4gLXsKPiA+ID4g Pj4gLSAgICAgICBpZiAoZmJkZXZfY21hKQo+ID4gPiA+PiAtCj4gPiA+ID4+IGRybV9mYl9oZWxw ZXJfc2V0X3N1c3BlbmRfdW5sb2NrZWQoJmZiZGV2X2NtYS0+ZmJfaGVscGVyLAo+ID4gPiA+PiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0ZSk7 Cj4gPiA+ID4+IC19Cj4gPiA+ID4+IC1FWFBPUlRfU1lNQk9MKGRybV9mYmRldl9jbWFfc2V0X3N1 c3BlbmRfdW5sb2NrZWQpOwo+ID4gPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuYwo+ID4gPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMgaW5kZXggMDJhZWU2Yy4uMjg4MjIwZiAxMDA2NDQKPiA+ID4gPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ID4gPiA+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gPiA+ID4+IEBAIC0zNTcsMzIgKzM1 NywxNSBAQCBzdGF0aWMgdm9pZCByY2FyX2R1X2xhc3RjbG9zZShzdHJ1Y3QgZHJtX2RldmljZQo+ ID4gPiA+PiAqZGV2KQo+ID4gPiA+PiAKPiA+ID4gPj4gIHN0YXRpYyBpbnQgcmNhcl9kdV9wbV9z dXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiA+ID4gPj4gIHsKPiA+ID4gPj4gIAo+ID4gPiA+ PiAgICAgICAgIHN0cnVjdCByY2FyX2R1X2RldmljZSAqcmNkdSA9IGRldl9nZXRfZHJ2ZGF0YShk ZXYpOwo+ID4gPiA+PiAKPiA+ID4gPj4gLSAgICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGU7Cj4gPiA+ID4+IAo+ID4gPiA+PiAtICAgICAgIGRybV9rbXNfaGVscGVyX3BvbGxfZGlz YWJsZShyY2R1LT5kZGV2KTsKPiA+ID4gPj4gLSAgICAgICBkcm1fZmJkZXZfY21hX3NldF9zdXNw ZW5kX3VubG9ja2VkKHJjZHUtPmZiZGV2LCB0cnVlKTsKPiA+ID4gPj4gLQo+ID4gPiA+PiAtICAg ICAgIHN0YXRlID0gZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZChyY2R1LT5kZGV2KTsKPiA+ID4g Pj4gLSAgICAgICBpZiAoSVNfRVJSKHN0YXRlKSkgewo+ID4gPiA+PiAtICAgICAgICAgICAgICAg ZHJtX2ZiZGV2X2NtYV9zZXRfc3VzcGVuZF91bmxvY2tlZChyY2R1LT5mYmRldiwKPiA+ID4gPj4g ZmFsc2UpOwo+ID4gPiA+PiAtICAgICAgICAgICAgICAgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFi bGUocmNkdS0+ZGRldik7Cj4gPiA+ID4+IC0gICAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUihz dGF0ZSk7Cj4gPiA+ID4+IC0gICAgICAgfQo+ID4gPiA+PiAtCj4gPiA+ID4+IC0gICAgICAgcmNk dS0+c3VzcGVuZF9zdGF0ZSA9IHN0YXRlOwo+ID4gPiA+PiAtCj4gPiA+ID4+IC0gICAgICAgcmV0 dXJuIDA7Cj4gPiA+ID4+ICsgICAgICAgcmV0dXJuIGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfc3Vz cGVuZChyY2R1LT5kZGV2KTsKPiA+ID4gPj4gCj4gPiA+ID4+ICB9Cj4gPiA+ID4+ICAKPiA+ID4g Pj4gIHN0YXRpYyBpbnQgcmNhcl9kdV9wbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ID4g PiA+PiAgewo+ID4gPiA+PiAgCj4gPiA+ID4+ICAgICAgICAgc3RydWN0IHJjYXJfZHVfZGV2aWNl ICpyY2R1ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gPiA+ID4+IAo+ID4gPiA+PiAtICAgICAg IGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZShyY2R1LT5kZGV2LCByY2R1LT5zdXNwZW5kX3N0YXRl KTsKPiA+ID4gPj4gLSAgICAgICBkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2VkKHJj ZHUtPmZiZGV2LCBmYWxzZSk7Cj4gPiA+ID4+IC0gICAgICAgZHJtX2ttc19oZWxwZXJfcG9sbF9l bmFibGUocmNkdS0+ZGRldik7Cj4gPiA+ID4+IC0KPiA+ID4gPj4gLSAgICAgICByZXR1cm4gMDsK PiA+ID4gPj4gKyAgICAgICByZXR1cm4gZHJtX21vZGVfY29uZmlnX2hlbHBlcl9yZXN1bWUocmNk dS0+ZGRldik7Cj4gPiA+ID4+IAo+ID4gPiA+PiAgfQo+ID4gPiA+PiAgI2VuZGlmCj4gPiA+ID4+ IAo+ID4gPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9k cnYuaAo+ID4gPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmggaW5k ZXggYjNhMjVlOC4uZmYyNWM4ZCAxMDA2NDQKPiA+ID4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L3JjYXItZHUvcmNhcl9kdV9kcnYuaAo+ID4gPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNh ci1kdS9yY2FyX2R1X2Rydi5oCj4gPiA+ID4+IEBAIC03OCw3ICs3OCw2IEBAIHN0cnVjdCByY2Fy X2R1X2RldmljZSB7Cj4gPiA+ID4+IAo+ID4gPiA+PiAgICAgICAgIHN0cnVjdCBkcm1fZGV2aWNl ICpkZGV2Owo+ID4gPiA+PiAgICAgICAgIHN0cnVjdCBkcm1fZmJkZXZfY21hICpmYmRldjsKPiA+ ID4gPj4gCj4gPiA+ID4+IC0gICAgICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN1c3BlbmRf c3RhdGU7Cj4gPiA+ID4+IAo+ID4gPiA+PiAgICAgICAgIHN0cnVjdCByY2FyX2R1X2NydGMgY3J0 Y3NbUkNBUl9EVV9NQVhfQ1JUQ1NdOwo+ID4gPiA+PiAgICAgICAgIHVuc2lnbmVkIGludCBudW1f Y3J0Y3M7Cj4gPiA+ID4+IAo+ID4gPiA+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Zi X2NtYV9oZWxwZXIuaAo+ID4gPiA+PiBiL2luY2x1ZGUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmgg aW5kZXggNGE2NWYwZC4uOGRiYmUxZSAxMDA2NDQKPiA+ID4gPj4gLS0tIGEvaW5jbHVkZS9kcm0v ZHJtX2ZiX2NtYV9oZWxwZXIuaAo+ID4gPiA+PiArKysgYi9pbmNsdWRlL2RybS9kcm1fZmJfY21h X2hlbHBlci5oCj4gPiA+ID4+IEBAIC0yNiw4ICsyNiw2IEBAIHN0cnVjdCBkcm1fZmJkZXZfY21h ICpkcm1fZmJkZXZfY21hX2luaXQoc3RydWN0Cj4gPiA+ID4+IGRybV9kZXZpY2UgKmRldiwKPiA+ ID4gPj4gCj4gPiA+ID4+ICB2b2lkIGRybV9mYmRldl9jbWFfcmVzdG9yZV9tb2RlKHN0cnVjdCBk cm1fZmJkZXZfY21hICpmYmRldl9jbWEpOwo+ID4gPiA+PiAgdm9pZCBkcm1fZmJkZXZfY21hX2hv dHBsdWdfZXZlbnQoc3RydWN0IGRybV9mYmRldl9jbWEgKmZiZGV2X2NtYSk7Cj4gPiA+ID4+IAo+ ID4gPiA+PiAtdm9pZCBkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2VkKHN0cnVjdCBk cm1fZmJkZXZfY21hCj4gPiA+ID4+ICpmYmRldl9jbWEsCj4gPiA+ID4+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIHN0YXRlKTsKPiA+ID4gPj4gCj4gPiA+ID4+ ICBzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpkcm1fZmJfY21hX2dldF9nZW1fb2JqKHN0cnVj dAo+ID4gPiA+PiAgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiA+ID4gPj4gIAo+ID4gPiA+PiAgICAg ICAgIHVuc2lnbmVkIGludCBwbGFuZSk7CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQK CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==