From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:55090 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbdCBAjv (ORCPT ); Wed, 1 Mar 2017 19:39:51 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter , "open list:DRM DRIVERS FOR RENESAS" , Laurent Pinchart Subject: Re: [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver Date: Thu, 02 Mar 2017 02:30:09 +0200 Message-ID: <2659133.LIMvdVgYOv@avalon> In-Reply-To: <7936513.8Ot9e1G3ck@avalon> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20170104145824.bnjdsv77bay75ie2@phenom.ffwll.local> <7936513.8Ot9e1G3ck@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Daniel, On Wednesday 04 Jan 2017 17:13:23 Laurent Pinchart wrote: > On Wednesday 04 Jan 2017 15:58:25 Daniel Vetter wrote: > > On Wed, Jan 04, 2017 at 04:33:57PM +0200, Laurent Pinchart wrote: > >> On Wednesday 04 Jan 2017 14:51:48 Daniel Vetter wrote: > >>> Hm, something like drm_bridge_panel_bridge_init(dev, panel) should be > >>> enough, or not? My idea is to use this for the case where the only > >>> thing in dt is the panel, with no real bridge chip. And I think we > >>> don't need anything beyond that one _init function, plus maybe some > >>> additional paramaters ... > >> > >> There should be no bridge then. If you want the DRM core to manage > >> panels automatically, then we should create specific helpers for that, > >> not abuse the bridge infrastructure. Bridges should be instantiated from > >> a hardware device and bound to drivers as usual. > > > > I guess that's the part where I disagree: Just because there's physically > > no bridge doesn't mean we shouldn't just treat it as one in the software > > abstraction. If it looks and acts like a bridge (even an empty one), then > > imo it can be a bridge. > > > > If you insist on panels being panels, then I guess we need some other kind > > of glue to bind them into arbitrary bridge chains. But given that the > > callbacks match very closely, I don't see the point. > > > > In an idea world a panel would probably derive from a drm_bridge, but > > we're not in that universe unfortunately ;-) > > Or both would derive from another object, but I agree that's how it should > work. That's what I want to achieve, one step at a time. Creating dummy > bridges isn't a step in that direction in my opinion, so I'd rather not do > that, but work towards the right abstraction. Do you object getting this patch merged as-is as a first step in the right direction ? :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver Date: Thu, 02 Mar 2017 02:30:09 +0200 Message-ID: <2659133.LIMvdVgYOv@avalon> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20170104145824.bnjdsv77bay75ie2@phenom.ffwll.local> <7936513.8Ot9e1G3ck@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id D21F06E1C8 for ; Thu, 2 Mar 2017 00:29:34 +0000 (UTC) In-Reply-To: <7936513.8Ot9e1G3ck@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: "open list:DRM DRIVERS FOR RENESAS" , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gV2VkbmVzZGF5IDA0IEphbiAyMDE3IDE3OjEzOjIzIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gT24gV2VkbmVzZGF5IDA0IEphbiAyMDE3IDE1OjU4OjI1IERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBXZWQsIEphbiAwNCwgMjAxNyBhdCAwNDozMzo1N1BNICswMjAw LCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4+IE9uIFdlZG5lc2RheSAwNCBKYW4gMjAxNyAx NDo1MTo0OCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4+PiBIbSwgc29tZXRoaW5nIGxpa2UgZHJt X2JyaWRnZV9wYW5lbF9icmlkZ2VfaW5pdChkZXYsIHBhbmVsKSBzaG91bGQgYmUKPiA+Pj4gZW5v dWdoLCBvciBub3Q/IE15IGlkZWEgaXMgdG8gdXNlIHRoaXMgZm9yIHRoZSBjYXNlIHdoZXJlIHRo ZSBvbmx5Cj4gPj4+IHRoaW5nIGluIGR0IGlzIHRoZSBwYW5lbCwgd2l0aCBubyByZWFsIGJyaWRn ZSBjaGlwLiBBbmQgSSB0aGluayB3ZQo+ID4+PiBkb24ndCBuZWVkIGFueXRoaW5nIGJleW9uZCB0 aGF0IG9uZSBfaW5pdCBmdW5jdGlvbiwgcGx1cyBtYXliZSBzb21lCj4gPj4+IGFkZGl0aW9uYWwg cGFyYW1hdGVycyAuLi4KPiA+PiAKPiA+PiBUaGVyZSBzaG91bGQgYmUgbm8gYnJpZGdlIHRoZW4u IElmIHlvdSB3YW50IHRoZSBEUk0gY29yZSB0byBtYW5hZ2UKPiA+PiBwYW5lbHMgYXV0b21hdGlj YWxseSwgdGhlbiB3ZSBzaG91bGQgY3JlYXRlIHNwZWNpZmljIGhlbHBlcnMgZm9yIHRoYXQsCj4g Pj4gbm90IGFidXNlIHRoZSBicmlkZ2UgaW5mcmFzdHJ1Y3R1cmUuIEJyaWRnZXMgc2hvdWxkIGJl IGluc3RhbnRpYXRlZCBmcm9tCj4gPj4gYSBoYXJkd2FyZSBkZXZpY2UgYW5kIGJvdW5kIHRvIGRy aXZlcnMgYXMgdXN1YWwuCj4gPiAKPiA+IEkgZ3Vlc3MgdGhhdCdzIHRoZSBwYXJ0IHdoZXJlIEkg ZGlzYWdyZWU6IEp1c3QgYmVjYXVzZSB0aGVyZSdzIHBoeXNpY2FsbHkKPiA+IG5vIGJyaWRnZSBk b2Vzbid0IG1lYW4gd2Ugc2hvdWxkbid0IGp1c3QgdHJlYXQgaXQgYXMgb25lIGluIHRoZSBzb2Z0 d2FyZQo+ID4gYWJzdHJhY3Rpb24uIElmIGl0IGxvb2tzIGFuZCBhY3RzIGxpa2UgYSBicmlkZ2Ug KGV2ZW4gYW4gZW1wdHkgb25lKSwgdGhlbgo+ID4gaW1vIGl0IGNhbiBiZSBhIGJyaWRnZS4KPiA+ IAo+ID4gSWYgeW91IGluc2lzdCBvbiBwYW5lbHMgYmVpbmcgcGFuZWxzLCB0aGVuIEkgZ3Vlc3Mg d2UgbmVlZCBzb21lIG90aGVyIGtpbmQKPiA+IG9mIGdsdWUgdG8gYmluZCB0aGVtIGludG8gYXJi aXRyYXJ5IGJyaWRnZSBjaGFpbnMuIEJ1dCBnaXZlbiB0aGF0IHRoZQo+ID4gY2FsbGJhY2tzIG1h dGNoIHZlcnkgY2xvc2VseSwgSSBkb24ndCBzZWUgdGhlIHBvaW50Lgo+ID4gCj4gPiBJbiBhbiBp ZGVhIHdvcmxkIGEgcGFuZWwgd291bGQgcHJvYmFibHkgZGVyaXZlIGZyb20gYSBkcm1fYnJpZGdl LCBidXQKPiA+IHdlJ3JlIG5vdCBpbiB0aGF0IHVuaXZlcnNlIHVuZm9ydHVuYXRlbHkgOy0pCj4g Cj4gT3IgYm90aCB3b3VsZCBkZXJpdmUgZnJvbSBhbm90aGVyIG9iamVjdCwgYnV0IEkgYWdyZWUg dGhhdCdzIGhvdyBpdCBzaG91bGQKPiB3b3JrLiBUaGF0J3Mgd2hhdCBJIHdhbnQgdG8gYWNoaWV2 ZSwgb25lIHN0ZXAgYXQgYSB0aW1lLiBDcmVhdGluZyBkdW1teQo+IGJyaWRnZXMgaXNuJ3QgYSBz dGVwIGluIHRoYXQgZGlyZWN0aW9uIGluIG15IG9waW5pb24sIHNvIEknZCByYXRoZXIgbm90IGRv Cj4gdGhhdCwgYnV0IHdvcmsgdG93YXJkcyB0aGUgcmlnaHQgYWJzdHJhY3Rpb24uCgpEbyB5b3Ug b2JqZWN0IGdldHRpbmcgdGhpcyBwYXRjaCBtZXJnZWQgYXMtaXMgYXMgYSBmaXJzdCBzdGVwIGlu IHRoZSByaWdodCAKZGlyZWN0aW9uID8gOi0pCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hh cnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=