From: Kevin Brodsky <kevin.brodsky@arm.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: kernel BUG around vmap/vfree - xen_enter_lazy_mmu()/xen_leave_lazy_mmu() - Linux 7.0-rc1
Date: Fri, 8 May 2026 13:34:33 +0200 [thread overview]
Message-ID: <265c0534-b480-4ab8-8f8a-2b5b8e7ca591@arm.com> (raw)
In-Reply-To: <be5b5e70-a61e-4803-9f40-873ce5381328@suse.com>
On 08/05/2026 12:09, Jürgen Groß wrote:
>
> OTOH I don't like the multiple conditions used for testing
> (state->enable_count,
> TIF_LAZY_MMU_UPDATES, xen_lazy_mode).
>
> Another variant would be to just let the Xen specific code tolerate
> the double
> calls by disabling preemption in the Xen code and checking via
> __task_lazy_mmu_mode_active() if anything needs to be done.
>
> I'd really like to get rid of xen_lazy_mode completely.
That certainly crossed my mind, but I didn't feel qualified to perform
that kind of surgery, especially considering XEN_LAZY_CPU. There is
presumably a good reason to track this one via a percpu variable, but
for the MMU side it feels like this creates more problems than it
solves. Maybe it is possible to keep XEN_LAZY_CPU untouched while
removing XEN_LAZY_MMU and using is_lazy_mmu_mode_active() instead? If we
do that, I don't think preemption is a concern - the lazy MMU mode is
only relevant for current and cannot be used in interrupt context.
- Kevin
prev parent reply other threads:[~2026-05-08 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 13:17 kernel BUG around vmap/vfree - xen_enter_lazy_mmu()/xen_leave_lazy_mmu() - Linux 7.0-rc1 Marek Marczykowski-Górecki
2026-02-26 13:27 ` Andrew Cooper
2026-02-26 13:36 ` Marek Marczykowski-Górecki
2026-02-26 13:41 ` Jürgen Groß
2026-04-05 9:41 ` Marek Marczykowski-Górecki
2026-04-07 9:23 ` Kevin Brodsky
2026-04-08 2:47 ` Marek Marczykowski-Górecki
2026-04-08 10:38 ` Kevin Brodsky
2026-05-07 16:31 ` Jürgen Groß
2026-05-08 8:53 ` Juergen Gross
2026-05-08 9:54 ` Kevin Brodsky
2026-05-08 10:09 ` Jürgen Groß
2026-05-08 10:28 ` Andrew Cooper
2026-05-08 11:34 ` Kevin Brodsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265c0534-b480-4ab8-8f8a-2b5b8e7ca591@arm.com \
--to=kevin.brodsky@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.