From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, dmitry.kozliuk@gmail.com,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [RFC] toolchain specific macro expansion
Date: Thu, 24 Jun 2021 18:29:20 +0200 [thread overview]
Message-ID: <2661083.m9YJQ7Gqa3@thomas> (raw)
In-Reply-To: <20210624160228.GB22718@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
24/06/2021 18:02, Tyler Retzlaff:
> On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote:
> > 23/06/2021 20:26, Tyler Retzlaff:
> > > // lib/eal/gcc/rte_toolchain_common.h
> > > #define __rte_noreturn __attribute__((noreturn))
> >
> > We should keep a macro in rte_common.h which triggers an explicit error
>
> i think that's relatively trivial to do. rte_common.h could after
> toolchain specific include do a simple test.
>
> #ifndef __rte_no_return
> #error no __rte_no_return defined for toolchain
> #endif
No I was thinking of:
/** Doxygen comment for the attribute below */
#define __rte_no_return RTE_ATTR_NOT_SUPPORTED
This way we have a documentation in a single place for the macro,
and compilation fails if it is not implemented for the toolchain.
next prev parent reply other threads:[~2021-06-24 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 18:26 [dpdk-dev] [RFC] toolchain specific macro expansion Tyler Retzlaff
2021-06-24 6:54 ` Thomas Monjalon
2021-06-24 16:02 ` Tyler Retzlaff
2021-06-24 16:29 ` Thomas Monjalon [this message]
2021-06-28 14:33 ` Tyler Retzlaff
2021-07-07 20:23 ` Tyler Retzlaff
2021-07-07 20:35 ` Thomas Monjalon
2021-07-07 20:56 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2661083.m9YJQ7Gqa3@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.