From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
"Antonio Quartulli" <a@unstable.cc>
Subject: Re: [PATCH v5 0/3] batman-adv: add dynamic, bridged-in TT VID detection
Date: Sat, 01 Feb 2025 10:42:54 +0100 [thread overview]
Message-ID: <2662292.atdPhlSkOF@sven-l14> (raw)
In-Reply-To: <20250201043725.15217-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 3984 bytes --]
On Saturday, 1 February 2025 05:31:27 GMT+1 Linus Lüssing wrote:
> v5:
> * rebased to current main branch:
> -> PATCH 3/3 needed to readd the include for soft-interface.h for
> batadv_softif_get_bridge() since commit
> "50eddf397ac3 batman-adv: netlink: reduce duplicate code by returning interfaces"
I see also following reports:
ecsv/pu: headers
----------------
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 051e7fce..30f65708 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -23,6 +23,7 @@
#include <linux/kref.h>
#include <linux/list.h>
#include <linux/lockdep.h>
+#include <linux/net.h>
#include <linux/netdevice.h>
#include <linux/netlink.h>
#include <linux/percpu.h>
ecsv/pu: kerneldoc ./net/batman-adv/soft-interface.c
----------------------------------------------------
./net/batman-adv/soft-interface.c:566: warning: Function parameter or struct member 'own' not described in 'batadv_softif_create_vlan'
./net/batman-adv/soft-interface.c:626: warning: Function parameter or struct member 'own' not described in 'batadv_softif_vlan_get_or_create'
ecsv/pu: unused_symbols
-----------------------
cfg:
* unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n
* unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=y
* unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y
batadv_softif_get_bridge
I am guessing I must just ignore the latter because it is only relevant for
non-mcast build and the noise from the extra #ifdef around "static" isn't
worth it.
The the linux/net.h "dependency" came with the second patch
Btw. I am still waiting for reviews from Antonio
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-02-01 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 4:31 [PATCH v5 0/3] batman-adv: add dynamic, bridged-in TT VID detection Linus Lüssing
2025-02-01 4:31 ` [PATCH v5 1/3] batman-adv: add dynamic, bridged-in TT VID detection support Linus Lüssing
2025-02-01 4:31 ` [PATCH v5 2/3] batman-adv: limit number of learned VLANs from bridged-in clients Linus Lüssing
2025-02-01 4:31 ` [PATCH v5 3/3] batman-adv: avoid adding bridge VLAN IDs through ndo_vlan_rx_add_vid() Linus Lüssing
2025-02-01 9:42 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2662292.atdPhlSkOF@sven-l14 \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.