From: Thomas Monjalon <thomas@monjalon.net>
To: Shreesh Adiga <16567adigashreesh@gmail.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Jasvinder Singh <jasvinder.singh@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH] net/crc: reduce usage of static arrays in net_crc_sse.c
Date: Wed, 24 Sep 2025 16:58:18 +0200 [thread overview]
Message-ID: <2664319.yIU609i1g2@thomas> (raw)
In-Reply-To: <20250716103439.831760-1-16567adigashreesh@gmail.com>
Hello,
16/07/2025 12:34, Shreesh Adiga:
> Replace the clearing of lower 32 bits of XMM register with blend of
> zero register.
> Replace the clearing of upper 64 bits of XMM register with _mm_move_epi64.
> Clang is able to optimize away the AND + memory operand with the
> above sequence, however GCC is still emitting the code for AND with
> memory operands which is being explicitly eliminated here.
>
> Additionally replace the 48 byte crc_xmm_shift_tab with the contents of
> shf_table which is 32 bytes, achieving the same functionality.
>
> Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
Sorry I'm not following.
Please could you start with defining the goal of this patch?
Is it a code simplification or a performance optimization?
next prev parent reply other threads:[~2025-09-24 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 10:34 [PATCH] net/crc: reduce usage of static arrays in net_crc_sse.c Shreesh Adiga
2025-09-24 14:58 ` Thomas Monjalon [this message]
2025-09-29 16:28 ` Shreesh Adiga
2025-10-01 7:55 ` Thomas Monjalon
2025-10-01 10:24 ` Shreesh Adiga
2025-10-01 12:16 ` Thomas Monjalon
2025-10-09 16:41 ` Bruce Richardson
2025-10-10 14:31 ` Shreesh Adiga
2026-06-08 17:16 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2025-10-11 11:29 Shreesh Adiga
2025-10-22 17:30 ` Patrick Robb
2025-11-14 15:49 ` Bruce Richardson
2025-11-15 10:07 ` Shreesh Adiga
2026-06-08 17:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664319.yIU609i1g2@thomas \
--to=thomas@monjalon.net \
--cc=16567adigashreesh@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.