All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Phanendra Vukkisala <pvukkisala@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection
Date: Mon, 28 Oct 2019 18:09:29 +0100	[thread overview]
Message-ID: <26649674.DGTEfl1OhS@xps> (raw)
In-Reply-To: <CY4PR1801MB18637FAD3C4ECF2875A8BD15DE660@CY4PR1801MB1863.namprd18.prod.outlook.com>

28/10/2019 15:50, Pavan Nikhilesh Bhagavatula:
> >21/09/2019 20:16, pbhagavatula@marvell.com:
> >> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>
> >> Some kernel modules have '-' in their name when populated in
> >> '/sys/bus/pci/drivers/' where as the kernel always populates
> >> '/sys/modules/' with '_'.
> >> Replace '-' in module name with '_' to avoid script complaining
> >> that module not loaded.
> >
> >Sorry it does not look obvious to me.
> >Please, could you describe what is wrong and what is the real cause?
> >
> 
> dpdk-devbind.py can also be used to bind devices to kernel modules.
> Some kernel modules are registered with '-' in their name and are populated 
> with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_'

Sorry, still not clear.
What do you mean by "registered"?

> This confuses the current script making it unable to bind to such modules. The patch 
> addresses it by always replacing '-' with '_' when looking in /sys/modules/

Yes this sentence is clear (except it is /sys/module/).
Please send a v2 with a clear explanation.



  reply	other threads:[~2019-10-28 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 14:50 [dpdk-dev] [PATCH] usertools: enhance device bind script module detection Pavan Nikhilesh Bhagavatula
2019-10-28 17:09 ` Thomas Monjalon [this message]
2019-10-28 17:10   ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2019-09-21 18:16 pbhagavatula
2019-10-27 20:20 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26649674.DGTEfl1OhS@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.