From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: yocto@yoctoproject.org
Cc: Darren Hart <dvhart@linux.intel.com>, "Wold, Saul" <saul.wold@intel.com>
Subject: Re: [PATCH 1/1] ddimage: Add script for writing images to boot media
Date: Thu, 22 Mar 2012 17:45:25 +0000 [thread overview]
Message-ID: <26661316.CjVfTJnL8v@helios> (raw)
In-Reply-To: <4F6B4B98.6050106@linux.intel.com>
On Thursday 22 March 2012 08:56:08 Darren Hart wrote:
> On 03/21/2012 05:26 PM, Paul Eggleton wrote:
> > On Wednesday 21 March 2012 16:06:14 Darren Hart wrote:
> >> Any objections to this going in?
> >
> > No objections, looks like a really useful tool; a couple of suggestions
> > though (sorry for not looking at it earlier):
> >
> > * Is it worth checking if the target device is mounted and erroring out if
> > so?
> That's a good suggestion. Alright with you if that is a follow-on patch?
Sure, sounds fine to me.
> > * Not sure but it may be worth waiting a few seconds after the sync before
> > exiting; I've seen some hardware that returns control to userspace before
> > the hardware has actually finished writing.
>
> That may be, but anything we assume will be wrong for some hardware. The
> sticks I have flash an LED for a few seconds afterwards, indicating writing.
Many do, yes. I guess it was just a simple idea to avoid potential issues
particularly for those that don't have an LED.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2012-03-22 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 19:16 [PATCH 0/1] ddimage: Add script for writing images to boot media Darren Hart
2012-03-13 19:16 ` [PATCH 1/1] " Darren Hart
2012-03-21 23:06 ` Darren Hart
2012-03-22 0:26 ` Paul Eggleton
2012-03-22 15:56 ` Darren Hart
2012-03-22 17:45 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26661316.CjVfTJnL8v@helios \
--to=paul.eggleton@linux.intel.com \
--cc=dvhart@linux.intel.com \
--cc=saul.wold@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.