From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: tj@kernel.org, axboe@kernel.dk, Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"
Date: Fri, 03 Feb 2023 08:59:13 +0100 [thread overview]
Message-ID: <2666358.mvXUDI8C0e@natalenko.name> (raw)
In-Reply-To: <20230203081357.1385168-1-yukuai1@huaweicloud.com>
Hello.
On pátek 3. února 2023 9:13:57 CET Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
>
> This can save some memory, because after commit 0f7839955114 ("Revert
> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> include/linux/blkdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 41a41561b773..c6861c7fdad9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -54,7 +54,7 @@ extern struct class block_class;
> * Maximum number of blkcg policies allowed to be registered concurrently.
> * Defined here to simplify include dependency.
> */
> -#define BLKCG_MAX_POLS 6
> +#define BLKCG_MAX_POLS 5
>
> #define DISK_MAX_PARTS 256
> #define DISK_NAME_LEN 32
Last time I asked about reverting this change, it was suggested that we may keep it [1].
[1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170bd@kernel.dk/
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2023-02-03 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 8:13 [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS" Yu Kuai
2023-02-03 7:59 ` Oleksandr Natalenko [this message]
2023-02-03 8:13 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2666358.mvXUDI8C0e@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.