From: David Howells <dhowells@redhat.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: dhowells@redhat.com, Vineet Gupta <vineetg76@gmail.com>,
James Hogan <james.hogan@imgtec.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro
Date: Tue, 29 Oct 2013 13:59:07 +0000 [thread overview]
Message-ID: <26752.1383055147@warthog.procyon.org.uk> (raw)
In-Reply-To: <526FA1B7.4090808@asianux.com>
Chen Gang <gang.chen@asianux.com> wrote:
> >> > For "kernel/modsign_certificate.S", I recommend to expand the macro
> >> > which will shrink code line, either need not include additional header
> >> > file, I feel that will be simpler for both code reader and writers.
> > I recommend leaving that file alone. That gets moved to a .S file in patches
> > queued in the security tree.
>
> Excuse me, I am not quite familiar with our version merging, I guess
> your meaning is "this file will be removed, and the related contents
> will be in another .S file, so we need not fix it within this file".
>
> If what I guess is correct, I support your recommendation (and if what I
> guess is incorrect, please let me know, thanks). :-)
Sorry, I misread what you were saying. The code has already been split out of
the .c file of course (I'd forgotten that it had). In the security tree next
branch, the .S file gets renamed and slightly modified here:
http://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git/commit/?h=next&id=b56e5a17b6b9acd16997960504b9940d0d7984e7
David
next prev parent reply other threads:[~2013-10-29 13:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 10:30 [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro Chen Gang
2013-10-28 11:18 ` Max Filippov
2013-10-29 7:57 ` Chen Gang
2013-10-29 8:34 ` Max Filippov
2013-10-29 8:47 ` Chen Gang
2013-10-28 13:45 ` Vineet Gupta
2013-10-29 1:04 ` Chen Gang
2013-10-29 1:39 ` Chen Gang
2013-10-29 1:51 ` [PATCH v2] " Chen Gang
2013-10-29 5:55 ` Vineet Gupta
2013-10-29 6:07 ` Chen Gang
2013-11-01 5:45 ` Vineet Gupta
2013-11-21 9:58 ` Vineet Gupta
2013-11-21 10:52 ` Chen Gang
2014-01-03 12:38 ` Michal Marek
2014-01-06 5:36 ` Vineet Gupta
2014-01-06 9:26 ` Michal Marek
2014-01-09 6:41 ` Vineet Gupta
2014-01-10 15:48 ` Chen Gang
2014-01-12 1:59 ` [PATCH v3] " Chen Gang
2014-01-18 9:44 ` Chen Gang
2014-01-21 4:55 ` Vineet Gupta
2014-01-25 11:07 ` Chen Gang
2014-01-27 21:57 ` Michal Marek
2014-01-30 5:41 ` Chen Gang
2013-10-29 10:39 ` [PATCH] " David Howells
2013-10-29 11:53 ` Chen Gang
2013-10-29 13:59 ` David Howells [this message]
2013-10-30 0:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26752.1383055147@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vineetg76@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.