From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James (song wei)" Subject: Re: add the two command to add or delete the usb device instead of do it in QEMU console Date: Sun, 13 Dec 2009 18:41:12 -0800 (PST) Message-ID: <26772284.post@talk.nabble.com> References: <4ADE00CB020000200006F5E4@novprvlin0050.provo.novell.com> <20091213210931.GF16033@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20091213210931.GF16033@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Yes, you are right. Sorry, I'll send the patch. Pasi K=C3=A4rkk=C3=A4inen wrote: >=20 > On Tue, Oct 20, 2009 at 01:26:19AM -0600, James Song wrote: >> I rewrite the patch, pls check. I also put those as attachments. >>=20 >> Thanks, >> -James >>=20 >> Signed-off-by: James Song Wei <[1]jsong@novell.com> >>=20 > =20 >> diff -r 0705efd9c69e tools/python/xen/xend/server/SrvDomain.py >> --- a/tools/python/xen/xend/server/SrvDomain.py Fri Oct 16 09:04:53 >> 2009 >> +0100 >> +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Oct 19 10:15:06 >> 2009 >> +0800 >> @@ -225,6 +225,19 @@ >> self.acceptCommand(req) >> return self.xd.domain_reset(self.dom.getName()) >>=20 >> + def op_usb_add(self, op, req): >> + self.acceptCommand(req) >> + return req.threadRequest(self.do_usb_add, op, req) >> + >> + def do_usb_add(self, _, req): >> + return self.xd.domain_usb_add(self.dom.getName(), req) >> + >> + def op_usb_del(self, op, req): >> + self.acceptCommand(req) >> + return req.threadRequest(self.do_usb_add, op, req) >> + >> + def do_usb_del(self, _, req): >> + return self.xd.domain_usb_add(self.dom.getName(), req) >>=20 >=20 > Hello, >=20 > Shouldn't op_usb_del() use do_usb_del() and do_usb_del() use > domain_usb_del() ? >=20 > Or did I miss something?=20 >=20 > -- Pasi >=20 >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >=20 >=20 --=20 View this message in context: http://old.nabble.com/add-the-two-command-to-= add-or-delete-the-usb-device-instead-of-do-it-in-QEMU-console-tp25970825p26= 772284.html Sent from the Xen - Dev mailing list archive at Nabble.com.