From mboxrd@z Thu Jan  1 00:00:00 1970
From: "James (song wei)" <jsong@novell.com>
Subject: Re: [PATCH] fix bug in c/s 20332 Add commands to
	hotplug usb devices to hvm guests
Date: Mon, 14 Dec 2009 00:22:37 -0800 (PST)
Message-ID: <26774299.post@talk.nabble.com>
References: <26772352.post@talk.nabble.com>
	<20091214080028.GG16033@reaktio.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20091214080028.GG16033@reaktio.net>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


Sorry, thanks Pasi!
-James

Signed-off-by: James Song Wei  <jsong@novell.com>=20
diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py
--- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009
+0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 16:18:27 2009
+0800
@@ -234,10 +234,10 @@
 =20
     def op_usb_del(self, op, req):
         self.acceptCommand(req)
-        return req.threadRequest(self.do_usb_add, op, req)
+        return req.threadRequest(self.do_usb_del, op, req)
=20
     def do_usb_del(self, _, req):
-        return self.xd.domain_usb_add(self.dom.getName(), req)
+        return self.xd.domain_usb_del(self.dom.getName(), req)
=20
     def render_POST(self, req):
         return self.perform(req)


Pasi K=C3=A4rkk=C3=A4inen wrote:
>=20
> On Sun, Dec 13, 2009 at 06:53:46PM -0800, James (song wei) wrote:
>>=20
>> Signed-off-by: James Song Wei  <jsong@novell.com>=20
>> diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py
>> --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009
>> +0000
>> +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009
>> +0800
>> @@ -234,7 +234,7 @@
>>  =20
>>      def op_usb_del(self, op, req):
>>          self.acceptCommand(req)
>> -        return req.threadRequest(self.do_usb_add, op, req)
>> +        return req.threadRequest(self.do_usb_del, op, req)
>> =20
>>      def do_usb_del(self, _, req):
>>          return self.xd.domain_usb_add(self.dom.getName(), req)
>                                      ^^^
>=20
> do_usb_del() is still using domain_usb_add() ..
>=20
> -- Pasi
>=20
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>=20
>=20

--=20
View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-=
20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26774299=
.html
Sent from the Xen - Dev mailing list archive at Nabble.com.