From: "Heiko Stübner" <heiko@sntech.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
patches@linaro.org
Subject: Re: [PATCH 1/1] ARM: S3C24XX: Move rtc-core.h from plat to mach
Date: Wed, 15 Jan 2014 22:34:22 +0100 [thread overview]
Message-ID: <2677599.hxjB7meQWY@phil> (raw)
In-Reply-To: <1388400008-9113-1-git-send-email-sachin.kamat@linaro.org>
Am Montag, 30. Dezember 2013, 16:10:08 schrieb Sachin Kamat:
> plat/rtc-core.h is only referenced from mach-s3c24xx. Hence
> move it there to de-populate the plat directory. While at it
> also do some cleanup of the header file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
late, but as the patch is not merged yet:
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../plat => mach-s3c24xx/include/mach}/rtc-core.h | 13 ++++++-------
> arch/arm/mach-s3c24xx/s3c2416.c | 2 +-
> arch/arm/mach-s3c24xx/s3c2443.c | 2 +-
> 3 files changed, 8 insertions(+), 9 deletions(-)
> rename arch/arm/{plat-samsung/include/plat =>
> mach-s3c24xx/include/mach}/rtc-core.h (69%)
>
> diff --git a/arch/arm/plat-samsung/include/plat/rtc-core.h
> b/arch/arm/mach-s3c24xx/include/mach/rtc-core.h similarity index 69%
> rename from arch/arm/plat-samsung/include/plat/rtc-core.h
> rename to arch/arm/mach-s3c24xx/include/mach/rtc-core.h
> index 7b542f7b7938..4d5f5768f700 100644
> --- a/arch/arm/plat-samsung/include/plat/rtc-core.h
> +++ b/arch/arm/mach-s3c24xx/include/mach/rtc-core.h
> @@ -1,5 +1,4 @@
> -/* linux/arch/arm/plat-samsung/include/plat/rtc-core.h
> - *
> +/*
> * Copyright (c) 2011 Heiko Stuebner <heiko@sntech.de>
> *
> * Samsung RTC Controller core functions
> @@ -9,19 +8,19 @@
> * published by the Free Software Foundation.
> */
>
> -#ifndef __ASM_PLAT_RTC_CORE_H
> -#define __ASM_PLAT_RTC_CORE_H __FILE__
> +#ifndef __RTC_CORE_H
> +#define __RTC_CORE_H __FILE__
>
> /* These functions are only for use with the core support code, such as
> * the cpu specific initialisation code
> */
>
> +extern struct platform_device s3c_device_rtc;
> +
> /* re-define device name depending on support. */
> static inline void s3c_rtc_setname(char *name)
> {
> -#if defined(CONFIG_S3C_DEV_RTC) || defined(CONFIG_PLAT_S3C24XX)
> s3c_device_rtc.name = name;
> -#endif
> }
>
> -#endif /* __ASM_PLAT_RTC_CORE_H */
> +#endif /* __RTC_CORE_H */
> diff --git a/arch/arm/mach-s3c24xx/s3c2416.c
> b/arch/arm/mach-s3c24xx/s3c2416.c index cb77880029f7..a0b787505c02 100644
> --- a/arch/arm/mach-s3c24xx/s3c2416.c
> +++ b/arch/arm/mach-s3c24xx/s3c2416.c
> @@ -48,6 +48,7 @@
> #include <asm/system_misc.h>
>
> #include <mach/regs-s3c2443-clock.h>
> +#include <mach/rtc-core.h>
>
> #include <plat/gpio-core.h>
> #include <plat/gpio-cfg.h>
> @@ -61,7 +62,6 @@
> #include <plat/fb-core.h>
> #include <plat/nand-core.h>
> #include <plat/adc-core.h>
> -#include <plat/rtc-core.h>
> #include <plat/spi-core.h>
>
> #include "common.h"
> diff --git a/arch/arm/mach-s3c24xx/s3c2443.c
> b/arch/arm/mach-s3c24xx/s3c2443.c index faa1086924c4..4af858457b2f 100644
> --- a/arch/arm/mach-s3c24xx/s3c2443.c
> +++ b/arch/arm/mach-s3c24xx/s3c2443.c
> @@ -34,6 +34,7 @@
> #include <asm/system_misc.h>
>
> #include <mach/regs-s3c2443-clock.h>
> +#include <mach/rtc-core.h>
>
> #include <plat/gpio-core.h>
> #include <plat/gpio-cfg.h>
> @@ -43,7 +44,6 @@
> #include <plat/fb-core.h>
> #include <plat/nand-core.h>
> #include <plat/adc-core.h>
> -#include <plat/rtc-core.h>
> #include <plat/spi-core.h>
>
> static struct map_desc s3c2443_iodesc[] __initdata = {
next prev parent reply other threads:[~2014-01-15 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 10:40 [PATCH 1/1] ARM: S3C24XX: Move rtc-core.h from plat to mach Sachin Kamat
2014-01-15 21:34 ` Heiko Stübner [this message]
2014-01-23 1:24 ` kgene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2677599.hxjB7meQWY@phil \
--to=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.