From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: warn about release notes updates
Date: Thu, 20 May 2021 12:18:33 +0200 [thread overview]
Message-ID: <2678038.gk5r4CYnPT@thomas> (raw)
In-Reply-To: <CAJFAV8wNWPVYsvraWjFzHtPA69ZDc21ZUeanhMH5o9u1RuJUfQ@mail.gmail.com>
20/05/2021 11:59, David Marchand:
> On Thu, May 20, 2021 at 11:47 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 20/05/2021 09:58, David Marchand:
> > > + current_rn=${rel_notes_prefix}${major_version}_${minor_version}.rst
> > > +
> > > + ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix $1 |
> >
> > Only the +++ part should matters.
>
> It won't catch accidental removals.
Ah yes
> Besides, something that is not handled with my patch is renames.
I think we don't care about renames.
> But if we think those cases would be caught by reviewers, I can
> simplify this part in v2.
Catching any change (including removal) in old release notes look fine.
next prev parent reply other threads:[~2021-05-20 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 7:58 [dpdk-dev] [PATCH] devtools: warn about release notes updates David Marchand
2021-05-20 9:47 ` Thomas Monjalon
2021-05-20 9:59 ` David Marchand
2021-05-20 10:18 ` Thomas Monjalon [this message]
2021-05-20 10:39 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-05-20 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2678038.gk5r4CYnPT@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.