From: Martin Steigerwald <martin@lichtvoll.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.com>,
Ming Lei <ming.lei@redhat.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
stable@vger.kernel.org,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Subject: Re: [PATCH] Avoid that a kernel warning appears during system resume
Date: Sun, 17 Mar 2019 15:20:06 +0100 [thread overview]
Message-ID: <2683612.6HTjCspbsH@merkaba> (raw)
In-Reply-To: <7436af16-0e46-418f-cfec-1ae530b2a82a@acm.org>
Hi Bart.
Bart Van Assche - 16.03.19, 22:28:
> On 3/16/19 3:43 AM, Martin Steigerwald wrote:
> > Bart Van Assche - 16.03.19, 00:27:
> >> Since scsi_device_quiesce() skips SCSI devices that have another
> >> state than RUNNING, OFFLINE or TRANSPORT_OFFLINE,
> >> scsi_device_resume() should not complain about SCSI devices that
> >> have been skipped. Hence this patch. This patch avoids that the
> >> following warning appears>
> >> during resume:
> > Am I on CC cause one of those warnings appeared in bug reports from
> > me from quite some time ago?
[…]
> That's correct. I hope that you don't mind that I cc'ed you?
No, I don't mind.
Would you like me to apply the patch in order to test it? As it is just
about suppressing a kernel warning and not changing any major
functionality, I wondered whether you like me to do with this or whether
the CC is more JFYI.
> >> WARNING: CPU: 3 PID: 1039 at blk_clear_pm_only+0x2a/0x30
> >> CPU: 3 PID: 1039 Comm: kworker/u8:49 Not tainted 5.0.0+ #1
> >> Hardware name: LENOVO 4180F42/4180F42, BIOS 83ET75WW (1.45 )
> >
> > This at least does not appear to be this ThinkPad T520, as I have
> > BIOS version 1.49 already.
>
> The call trace in the patch description is only an example. I think
> the problem description and the patch applies to all systems that
> have one or more SCSI disks.
Best,
--
Martin
next prev parent reply other threads:[~2019-03-17 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 23:27 [PATCH] Avoid that a kernel warning appears during system resume Bart Van Assche
2019-03-16 10:43 ` Martin Steigerwald
2019-03-16 21:28 ` Bart Van Assche
2019-03-17 14:20 ` Martin Steigerwald [this message]
2019-03-17 17:19 ` Bart Van Assche
2019-03-19 18:27 ` Martin K. Petersen
[not found] ` <20190325003830.8BA272147C@mail.kernel.org>
2019-03-25 4:47 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2683612.6HTjCspbsH@merkaba \
--to=martin@lichtvoll.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.