From: Thomas Monjalon <thomas@monjalon.net>
To: Tonghao Zhang <nic@opencloud.tech>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] memzone: Check socket_id value when creating memzone.
Date: Mon, 05 Jun 2017 18:24:20 +0200 [thread overview]
Message-ID: <2684435.WV1LPMSqPV@xps> (raw)
In-Reply-To: <20170512084220.GB53020@bricha3-MOBL3.ger.corp.intel.com>
12/05/2017 10:42, Bruce Richardson:
> On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote:
> > If the socket_id is invalid (e.g. -2, -3), the
> > memzone_reserve_aligned_thread_unsafe should return the
> > EINVAL and not ENOMEM. To avoid it, we should check the
> > socket_id before calling malloc_heap_alloc.
> >
> > Signed-off-by: Tonghao Zhang <nic@opencloud.tech>
>
> Looks a sensible thing to do.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-06-05 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 6:03 [PATCH] memzone: Check socket_id value when creating memzone Tonghao Zhang
2017-05-12 8:42 ` Bruce Richardson
2017-05-17 0:31 ` nickcooper-zhangtonghao
2017-06-01 1:24 ` nickcooper-zhangtonghao
2017-06-05 16:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2684435.WV1LPMSqPV@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nic@opencloud.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.