From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-kmods v2] linux/igb_uio: fix build for switch fall through
Date: Tue, 11 Jan 2022 15:32:34 +0100 [thread overview]
Message-ID: <2684876.BEx9A2HvPv@thomas> (raw)
In-Reply-To: <20211216120349.2088759-1-ferruh.yigit@intel.com>
16/12/2021 13:03, Ferruh Yigit:
> Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't
> take any fall through comments into account but only uses compiler
> 'fallthrough' attribute to document fall through action is intended.
>
> "falls through" comment was used in the code which is causing a build
> error now, this patch converts comment to the 'fallthrough' macro
> defined in the Linux.
>
> To cover the case where an old Linux version doesn't have the macro,
> defined it in the compatibility header too.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-01-11 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:48 [dpdk-kmods] linux/igb_uio: fix build for switch fall through Ferruh Yigit
2021-12-15 19:20 ` Stephen Hemminger
2021-12-15 21:04 ` Ferruh Yigit
2021-12-15 23:15 ` Stephen Hemminger
2021-12-16 9:37 ` Ferruh Yigit
2021-12-16 12:03 ` [dpdk-kmods v2] " Ferruh Yigit
2022-01-11 14:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2684876.BEx9A2HvPv@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.