From: Michael Neuling <mikey@neuling.org>
To: maneesh@in.ibm.com
Cc: horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] fix kexec-tools options
Date: Thu, 24 May 2007 23:56:52 +1000 [thread overview]
Message-ID: <26898.1180015012@neuling.org> (raw)
In-Reply-To: <20070524124936.GA7982@in.ibm.com>
> o value for OPT_REUSE_INITRD clashes with arch specific options which are
> defined as (OPT_MAX + 1), like --serial option on x86_64. Changed the
> values so that OPT_REUSE_INITRD is less than OPT_MAX.
>
> Signed-off-by: Maneesh Soni <maneesh@in.ibm.com>
Oops.. thanks for fixing.
> ----
> --- kexec.h.orig 2007-05-15 10:06:33.000000000 +0530
> +++ kexec.h 2007-05-24 17:37:34.000000000 +0530
BTW the path has been stripped here, so this patch doesn't apply. I've
fixed it up and reposted below.
Mikey
o value for OPT_REUSE_INITRD clashes with arch specific options which
are defined as (OPT_MAX + 1), like --serial option on x86_64. Changed
the values so that OPT_REUSE_INITRD is less than OPT_MAX.
Signed-off-by: Maneesh Soni <maneesh@in.ibm.com>
Acked-by: Michael Neuling <mikey@neuling.org>
---
kexec/kexec.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: kexec-tools-testing/kexec/kexec.h
===================================================================
--- kexec-tools-testing.orig/kexec/kexec.h
+++ kexec-tools-testing/kexec/kexec.h
@@ -162,8 +162,8 @@ extern int file_types;
#define OPT_PANIC 'p'
#define OPT_MEM_MIN 256
#define OPT_MEM_MAX 257
-#define OPT_MAX 258
-#define OPT_REUSE_INITRD 259
+#define OPT_REUSE_INITRD 258
+#define OPT_MAX 259
#define KEXEC_OPTIONS \
{ "help", 0, 0, OPT_HELP }, \
{ "version", 0, 0, OPT_VERSION }, \
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2007-05-24 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 12:49 [PATCH] fix kexec-tools options Maneesh Soni
2007-05-24 13:56 ` Michael Neuling [this message]
2007-05-25 2:22 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26898.1180015012@neuling.org \
--to=mikey@neuling.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.