From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
pablo.de.lara.guarch@intel.com, yipeng1.wang@intel.com,
dharmik.thakkar@arm.com, gavin.hu@arm.com, nd@arm.com
Subject: Re: [PATCH v6 2/5] hash: support do not free on delete
Date: Fri, 26 Oct 2018 00:55:01 +0200 [thread overview]
Message-ID: <2691977.lcrpPM4Irn@xps> (raw)
In-Reply-To: <1540344746-29045-3-git-send-email-honnappa.nagarahalli@arm.com>
24/10/2018 03:32, Honnappa Nagarahalli:
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Free a hash key in the hash table given the position
> + * of the key. This operation is not multi-thread safe and should
> + * only be called from one thread by default. Thread safety
> + * can be enabled by setting flag during table creation.
> + * If RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is enabled,
> + * this API must be called, with the key index returned by rte_hash_add_key_xxx
> + * APIs, after the key is deleted using rte_hash_del_key_xxx APIs.
> + * This API does not validate if the key is already freed.
> + *
> + * @param h
> + * Hash table to free the key from.
> + * @param position
> + * Position returned when the key was deleted.
> + * @return
> + * - 0 if freed successfully
> + * - -EINVAL if the parameters are invalid.
> + */
> +int __rte_experimental
> +rte_hash_free_key_with_position(const struct rte_hash *h,
> + const int32_t position);
You need to add this new function to the map file,
otherwise linking of shared library will fail.
next prev parent reply other threads:[~2018-10-25 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 1:32 [PATCH v6 0/5] Address reader-writer concurrency in rte_hash Honnappa Nagarahalli
2018-10-24 1:32 ` [PATCH v6 1/5] hash: separate multi-writer from rw-concurrency Honnappa Nagarahalli
2018-10-24 1:32 ` [PATCH v6 2/5] hash: support do not free on delete Honnappa Nagarahalli
2018-10-25 22:55 ` Thomas Monjalon [this message]
2018-10-26 1:20 ` Honnappa Nagarahalli
2018-10-24 1:32 ` [PATCH v6 3/5] hash: fix key store element alignment Honnappa Nagarahalli
2018-10-24 1:32 ` [PATCH v6 4/5] hash: add lock-free read-write concurrency Honnappa Nagarahalli
2018-10-24 1:32 ` [PATCH v6 5/5] test/hash: read-write lock-free concurrency test Honnappa Nagarahalli
2018-10-25 22:56 ` [PATCH v6 0/5] Address reader-writer concurrency in rte_hash Thomas Monjalon
2018-10-26 0:48 ` Honnappa Nagarahalli
2018-10-26 8:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2691977.lcrpPM4Irn@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.