From: David Howells <dhowells@redhat.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: dhowells@redhat.com, ralf@linux-mips.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>, DM <dm.n9107@gmail.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy definitions.
Date: Wed, 23 Nov 2011 11:11:40 +0000 [thread overview]
Message-ID: <2694.1322046700@redhat.com> (raw)
In-Reply-To: <1321985686-798-3-git-send-email-ddaney.cavm@gmail.com>
David Daney <ddaney.cavm@gmail.com> wrote:
> From: David Daney <david.daney@cavium.com>
>
> The file linux/hugetlb.h has many places where dummy symbols were
> defined so that the main source code would contain fewer:
>
> #ifdef CONFIG_HUGETLBFS
>
> or
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>
> If there were any misuse of these symbols, the only symptom would be
> an OOPS at runtime. Change the BUG() to BUILD_BUG() to catch
> any such abuse at compile time instead.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2011-11-23 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 18:14 [PATCH v2 0/2] Stop some of the abuse of BUG() where compile time checks should be used David Daney
2011-11-22 18:14 ` David Daney
2011-11-22 18:14 ` [PATCH v2 1/2] kernel.h: Add BUILD_BUG() macro David Daney
2011-11-23 1:34 ` David Rientjes
2011-11-23 11:11 ` David Howells
2011-11-22 18:14 ` [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy definitions David Daney
2011-11-23 1:35 ` David Rientjes
2011-11-23 11:11 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2694.1322046700@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=dm.n9107@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.