From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized Date: Fri, 11 Nov 2016 20:49:48 +0100 Message-ID: <2695221.kyRJMsRMjs@wuerfel> References: <20161110164454.293477-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Sean Young , sayli karnik , Trond Myklebust , Srinivas Kandagatla , linux-s390 , Herbert Xu , the arch/x86 maintainers , Sebastian Ott , Russell King , Javier Martinez Canillas , Ilya Dryomov , arcml , Linux Media Mailing List , Linux Kbuild mailing list , Jiri Kosina , Mark Brown , nios2-dev@lists.rocketboards.org, Mauro Carvalho Chehab , Linux NFS Mailing List , gregkh@linuxfoundation.org, Linux Kernel Mailing List Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org T24gRnJpZGF5LCBOb3ZlbWJlciAxMSwgMjAxNiA5OjEzOjAwIEFNIENFVCBMaW51cyBUb3J2YWxk cyB3cm90ZToKPiBPbiBUaHUsIE5vdiAxMCwgMjAxNiBhdCA4OjQ0IEFNLCBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPiB3cm90ZToKPiA+Cj4gPiBQbGVhc2UgbWVyZ2UgdGhlc2UgZGlyZWN0 bHkgaWYgeW91IGFyZSBoYXBweSB3aXRoIHRoZSByZXN1bHQuCj4gCj4gSSB3aWxsIHRha2UgdGhp cy4KClRoYW5rcyBhIGxvdCEKIAo+IEkgZG8gc2VlIHR3byB3YXJuaW5ncywgYnV0IHRoZXkgYm90 aCBzZWVtIHRvIGJlIHZhbGlkIGFuZCByZWNlbnQsCj4gdGhvdWdoLCBzbyBJIGhhdmUgbm8gaXNz dWVzIHdpdGggdGhlIHNwdXJpb3VzIGNhc2VzLgoKT2ssIGJvdGggb2YgdGhlbSBzaG91bGQgaGF2 ZSBteSBmaXhlcyBjb21pbmcgeW91ciB3YXkgYWxyZWFkeS4KCj4gV2FybmluZyAjMToKPiAKPiAg IHNvdW5kL3NvYy9xY29tL2xwYXNzLXBsYXRmb3JtLmM6IEluIGZ1bmN0aW9uIOKAmGxwYXNzX3Bs YXRmb3JtX3BjbW9wc19vcGVu4oCZOgo+ICAgc291bmQvc29jL3Fjb20vbHBhc3MtcGxhdGZvcm0u Yzo4MzoyOTogd2FybmluZzog4oCYZG1hX2No4oCZIG1heSBiZSB1c2VkCj4gdW5pbml0aWFsaXpl ZCBpbiB0aGlzIGZ1bmN0aW9uIFstV21heWJlLXVuaW5pdGlhbGl6ZWRdCj4gICAgIGRydmRhdGEt PnN1YnN0cmVhbVtkbWFfY2hdID0gc3Vic3RyZWFtOwo+ICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5efn5+fn5+fn5+fgo+IAo+IGFuZCAnZG1hX2NoJyB1c2FnZSB0aGVyZSByZWFsbHkg aXMgY3JhenkgYW5kIHdyb25nLiBCcm9rZW4gYnkKPiAwMjJkMDBlZTBiNTUgKCJBU29DOiBscGFz cy1wbGF0Zm9ybTogRml4IGJyb2tlbiBwY20gZGF0YSB1c2FnZSIpCgpSaWdodCwgdGhlIHBhdGNo ZXMgY3Jvc3NlZCBoZXJlLCB0aGUgYnVnZml4IHBhdGNoIHRoYXQgaW50cm9kdWNlZAp0aGlzIGNh bWUgaW50byBsaW51eC1uZXh0IG92ZXIgdGhlIGtlcm5lbCBzdW1taXQsIGFuZCB0aGUgZml4IEkK c2VudCBvbiBUdWVzZGF5IG1hZGUgaXQgaW50byBNYXJrIEJyb3duJ3MgdHJlZSBvbiBXZWRuZXNk YXkgYnV0IG5vdApiZWZvcmUgeW91IHB1bGxlZCBhbHNhIHRyZWUuIEl0IHNob3VsZCBiZSBmaXhl ZCB0aGUgbmV4dCB0aW1lIHlvdQpwdWxsIGZyb20gdGhlIGFsc2EgdHJlZSwgdGhlIGNvbW1pdCBp cwoKM2I4OWU0Yjc3ZWY5ICgiQVNvQzogbHBhc3MtcGxhdGZvcm06IGluaXRpYWxpemUgZG1hIGNo YW5uZWwgbnVtYmVyIikKIAo+IFdhcm5pbmcgIzIgaXMgbm90IGEgcmVhbCBidWcsIGJ1dCBpdCdz IHJlYXNvbmFibGUgdGhhdCBnY2MgZG9lc24ndAo+IGtub3cgdGhhdCBzdG9yYWdlX2J5dGVzIChj aGlwLT5yZWFkX3NpemUpIGhhcyB0byBiZSAyLzQuIEFnYWluLAo+IGludHJvZHVjZWQgcmVjZW50 bHkgYnkgY29tbWl0IDIzMTE0N2VlNzdmMyAoImlpbzogbWF4aW1fdGhlcm1vY291cGxlOgo+IEFs aWduIDE2IGJpdCBiaWcgZW5kaWFuIHZhbHVlIG9mIHJhdyByZWFkcyIpLCBzbyB5b3UgZGlkbid0 IHNlZSBpdC4KClRoaXMgaXMgdGhlIG9uZSBJIG1lbnRpb25lZCBpbiB0aGUgY29tbWl0IG1lc3Nh Z2UgYXMgb25lIHRoYXQKaXMgZml4ZWQgaW4gbGludXgtbmV4dCBhbmQgdGhhdCBzaG91bGQgbWFr ZSBpdCBpbiBzb29uLgoKPiAgIGRyaXZlcnMvaWlvL3RlbXBlcmF0dXJlL21heGltX3RoZXJtb2Nv dXBsZS5jOiBJbiBmdW5jdGlvbgo+IOKAmG1heGltX3RoZXJtb2NvdXBsZV9yZWFkX3Jhd+KAmToK PiAgIGRyaXZlcnMvaWlvL3RlbXBlcmF0dXJlL21heGltX3RoZXJtb2NvdXBsZS5jOjE0MTo1OiB3 YXJuaW5nOiDigJhyZXTigJkKPiBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVu Y3Rpb24gWy1XbWF5YmUtdW5pbml0aWFsaXplZF0KPiAgICAgaWYgKHJldCkKPiAgICAgICAgXgo+ ICAgZHJpdmVycy9paW8vdGVtcGVyYXR1cmUvbWF4aW1fdGhlcm1vY291cGxlLmM6MTI4OjY6IG5v dGU6IOKAmHJldOKAmSB3YXMKPiBkZWNsYXJlZCBoZXJlCj4gICAgIGludCByZXQ7Cj4gICAgICAg ICBefn4KPiAKPiBhbmQgSSBndWVzcyB0aGF0IGNvZGUgY2FuIGp1c3QgaW5pdGlhbGl6ZSAncmV0 JyB0byAnLUVJTlZBTCcgb3IKPiBzb21ldGhpbmcgdG8ganVzdCBtYWtlIHRoZSB0aGVvcmV0aWNh bCAic29tZWhvdyB3ZSBoYWQgYSB3cm9uZwo+IGNoaXAtPnJlYWRfc2l6ZSIgY2FzZSBlcnJvciBv dXQgY2xlYW5seS4KClJpZ2h0LCB0aGF0IHdhcyBteSBjb25jbHVzaW9uIHRvby4gSSBzZW50IHRo ZSBidWdmaXggb24gT2N0IDI1CmZvciBsaW51eC1uZXh0IGJ1dCBpdCBkaWRuJ3QgbWFrZSBpdCBp biB1bnRpbCB0aGlzIE1vbmRheSwgYWZ0ZXIKeW91IHB1bGxlZCB0aGUgcGF0Y2ggdGhhdCBpbnRy b2R1Y2VkIGl0IG9uIE9jdCAyOS4KClRoZSBjb21taXQgaW4gc3RhZ2luZy10ZXN0aW5nIGlzCjMy Y2I3ZDI3ZTY1ZCAoImlpbzogbWF4aW1fdGhlcm1vY291cGxlOiBkZXRlY3QgaW52YWxpZCBzdG9y YWdlIHNpemUgaW4gcmVhZCgpIikKCkdyZWcgYW5kIEpvbmF0aGFuLCBJIHNlZSBub3cgdGhhdCB0 aGlzIGlzIHBhcnQgb2YgdGhlICdpaW8tZm9yLTQuMTBiJwpicmFuY2gsIHNvIEkgc3VzcGVjdCB5 b3Ugd2VyZSBub3QgcGxhbm5pbmcgdG8gc2VuZCB0aGlzIGJlZm9yZSB0aGUKbWVyZ2Ugd2luZG93 LiBDb3VsZCB5b3UgbWFrZSBzdXJlIHRoaXMgZW5kcyB1cCBpbiB2NC45IHNvIHdlIGdldAphIGNs ZWFuIGJ1aWxkIHdoZW4gLVdtYXliZS11bmluaXRpYWxpemVkIGdldHMgZW5hYmxlZCBhZ2Fpbj8K CglBcm5kCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1zbnBzLWFyYyBtYWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNu cHMtYXJj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.131]:49881 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932697AbcKKTvM (ORCPT ); Fri, 11 Nov 2016 14:51:12 -0500 From: Arnd Bergmann Subject: Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized Date: Fri, 11 Nov 2016 20:49:48 +0100 Message-ID: <2695221.kyRJMsRMjs@wuerfel> In-Reply-To: References: <20161110164454.293477-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Srinivas Kandagatla , sayli karnik , Jonathan Cameron , Mark Brown , Andrew Morton , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , the arch/x86 maintainers , Linux Kbuild mailing list , Linux Kernel Mailing List , arcml , nios2-dev@lists.rocketboards.org, linux-s390 , Linux Crypto Mailing List , Linux Media Mailing List , Linux NFS Mailing List , gregkh@linuxfoundation.org On Friday, November 11, 2016 9:13:00 AM CET Linus Torvalds wrote: > On Thu, Nov 10, 2016 at 8:44 AM, Arnd Bergmann wrote: > > > > Please merge these directly if you are happy with the result. > > I will take this. Thanks a lot! > I do see two warnings, but they both seem to be valid and recent, > though, so I have no issues with the spurious cases. Ok, both of them should have my fixes coming your way already. > Warning #1: > > sound/soc/qcom/lpass-platform.c: In function ‘lpass_platform_pcmops_open’: > sound/soc/qcom/lpass-platform.c:83:29: warning: ‘dma_ch’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > drvdata->substream[dma_ch] = substream; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ > > and 'dma_ch' usage there really is crazy and wrong. Broken by > 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Right, the patches crossed here, the bugfix patch that introduced this came into linux-next over the kernel summit, and the fix I sent on Tuesday made it into Mark Brown's tree on Wednesday but not before you pulled alsa tree. It should be fixed the next time you pull from the alsa tree, the commit is 3b89e4b77ef9 ("ASoC: lpass-platform: initialize dma channel number") > Warning #2 is not a real bug, but it's reasonable that gcc doesn't > know that storage_bytes (chip->read_size) has to be 2/4. Again, > introduced recently by commit 231147ee77f3 ("iio: maxim_thermocouple: > Align 16 bit big endian value of raw reads"), so you didn't see it. This is the one I mentioned in the commit message as one that is fixed in linux-next and that should make it in soon. > drivers/iio/temperature/maxim_thermocouple.c: In function > ‘maxim_thermocouple_read_raw’: > drivers/iio/temperature/maxim_thermocouple.c:141:5: warning: ‘ret’ > may be used uninitialized in this function [-Wmaybe-uninitialized] > if (ret) > ^ > drivers/iio/temperature/maxim_thermocouple.c:128:6: note: ‘ret’ was > declared here > int ret; > ^~~ > > and I guess that code can just initialize 'ret' to '-EINVAL' or > something to just make the theoretical "somehow we had a wrong > chip->read_size" case error out cleanly. Right, that was my conclusion too. I sent the bugfix on Oct 25 for linux-next but it didn't make it in until this Monday, after you pulled the patch that introduced it on Oct 29. The commit in staging-testing is 32cb7d27e65d ("iio: maxim_thermocouple: detect invalid storage size in read()") Greg and Jonathan, I see now that this is part of the 'iio-for-4.10b' branch, so I suspect you were not planning to send this before the merge window. Could you make sure this ends up in v4.9 so we get a clean build when -Wmaybe-uninitialized gets enabled again? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized Date: Fri, 11 Nov 2016 20:49:48 +0100 Message-ID: <2695221.kyRJMsRMjs@wuerfel> References: <20161110164454.293477-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org List-Archive: List-Post: To: Linus Torvalds Cc: Sean Young , sayli karnik , Trond Myklebust , Srinivas Kandagatla , linux-s390 , Herbert Xu , the arch/x86 maintainers , Sebastian Ott , Russell King , Javier Martinez Canillas , Ilya Dryomov , arcml , Linux Media Mailing List , Linux Kbuild mailing list , Jiri Kosina , Mark Brown , nios2-dev@lists.rocketboards.org, Mauro Carvalho Chehab , Linux NFS Mailing List , gregkh@linuxfoundation.orgLinux Kernel Mailing List List-ID: T24gRnJpZGF5LCBOb3ZlbWJlciAxMSwgMjAxNiA5OjEzOjAwIEFNIENFVCBMaW51cyBUb3J2YWxk cyB3cm90ZToKPiBPbiBUaHUsIE5vdiAxMCwgMjAxNiBhdCA4OjQ0IEFNLCBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPiB3cm90ZToKPiA+Cj4gPiBQbGVhc2UgbWVyZ2UgdGhlc2UgZGlyZWN0 bHkgaWYgeW91IGFyZSBoYXBweSB3aXRoIHRoZSByZXN1bHQuCj4gCj4gSSB3aWxsIHRha2UgdGhp cy4KClRoYW5rcyBhIGxvdCEKIAo+IEkgZG8gc2VlIHR3byB3YXJuaW5ncywgYnV0IHRoZXkgYm90 aCBzZWVtIHRvIGJlIHZhbGlkIGFuZCByZWNlbnQsCj4gdGhvdWdoLCBzbyBJIGhhdmUgbm8gaXNz dWVzIHdpdGggdGhlIHNwdXJpb3VzIGNhc2VzLgoKT2ssIGJvdGggb2YgdGhlbSBzaG91bGQgaGF2 ZSBteSBmaXhlcyBjb21pbmcgeW91ciB3YXkgYWxyZWFkeS4KCj4gV2FybmluZyAjMToKPiAKPiAg IHNvdW5kL3NvYy9xY29tL2xwYXNzLXBsYXRmb3JtLmM6IEluIGZ1bmN0aW9uIOKAmGxwYXNzX3Bs YXRmb3JtX3BjbW9wc19vcGVu4oCZOgo+ICAgc291bmQvc29jL3Fjb20vbHBhc3MtcGxhdGZvcm0u Yzo4MzoyOTogd2FybmluZzog4oCYZG1hX2No4oCZIG1heSBiZSB1c2VkCj4gdW5pbml0aWFsaXpl ZCBpbiB0aGlzIGZ1bmN0aW9uIFstV21heWJlLXVuaW5pdGlhbGl6ZWRdCj4gICAgIGRydmRhdGEt PnN1YnN0cmVhbVtkbWFfY2hdID0gc3Vic3RyZWFtOwo+ICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5efn5+fn5+fn5+fgo+IAo+IGFuZCAnZG1hX2NoJyB1c2FnZSB0aGVyZSByZWFsbHkg aXMgY3JhenkgYW5kIHdyb25nLiBCcm9rZW4gYnkKPiAwMjJkMDBlZTBiNTUgKCJBU29DOiBscGFz cy1wbGF0Zm9ybTogRml4IGJyb2tlbiBwY20gZGF0YSB1c2FnZSIpCgpSaWdodCwgdGhlIHBhdGNo ZXMgY3Jvc3NlZCBoZXJlLCB0aGUgYnVnZml4IHBhdGNoIHRoYXQgaW50cm9kdWNlZAp0aGlzIGNh bWUgaW50byBsaW51eC1uZXh0IG92ZXIgdGhlIGtlcm5lbCBzdW1taXQsIGFuZCB0aGUgZml4IEkK c2VudCBvbiBUdWVzZGF5IG1hZGUgaXQgaW50byBNYXJrIEJyb3duJ3MgdHJlZSBvbiBXZWRuZXNk YXkgYnV0IG5vdApiZWZvcmUgeW91IHB1bGxlZCBhbHNhIHRyZWUuIEl0IHNob3VsZCBiZSBmaXhl ZCB0aGUgbmV4dCB0aW1lIHlvdQpwdWxsIGZyb20gdGhlIGFsc2EgdHJlZSwgdGhlIGNvbW1pdCBp cwoKM2I4OWU0Yjc3ZWY5ICgiQVNvQzogbHBhc3MtcGxhdGZvcm06IGluaXRpYWxpemUgZG1hIGNo YW5uZWwgbnVtYmVyIikKIAo+IFdhcm5pbmcgIzIgaXMgbm90IGEgcmVhbCBidWcsIGJ1dCBpdCdz IHJlYXNvbmFibGUgdGhhdCBnY2MgZG9lc24ndAo+IGtub3cgdGhhdCBzdG9yYWdlX2J5dGVzIChj aGlwLT5yZWFkX3NpemUpIGhhcyB0byBiZSAyLzQuIEFnYWluLAo+IGludHJvZHVjZWQgcmVjZW50 bHkgYnkgY29tbWl0IDIzMTE0N2VlNzdmMyAoImlpbzogbWF4aW1fdGhlcm1vY291cGxlOgo+IEFs aWduIDE2IGJpdCBiaWcgZW5kaWFuIHZhbHVlIG9mIHJhdyByZWFkcyIpLCBzbyB5b3UgZGlkbid0 IHNlZSBpdC4KClRoaXMgaXMgdGhlIG9uZSBJIG1lbnRpb25lZCBpbiB0aGUgY29tbWl0IG1lc3Nh Z2UgYXMgb25lIHRoYXQKaXMgZml4ZWQgaW4gbGludXgtbmV4dCBhbmQgdGhhdCBzaG91bGQgbWFr ZSBpdCBpbiBzb29uLgoKPiAgIGRyaXZlcnMvaWlvL3RlbXBlcmF0dXJlL21heGltX3RoZXJtb2Nv dXBsZS5jOiBJbiBmdW5jdGlvbgo+IOKAmG1heGltX3RoZXJtb2NvdXBsZV9yZWFkX3Jhd+KAmToK PiAgIGRyaXZlcnMvaWlvL3RlbXBlcmF0dXJlL21heGltX3RoZXJtb2NvdXBsZS5jOjE0MTo1OiB3 YXJuaW5nOiDigJhyZXTigJkKPiBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVu Y3Rpb24gWy1XbWF5YmUtdW5pbml0aWFsaXplZF0KPiAgICAgaWYgKHJldCkKPiAgICAgICAgXgo+ ICAgZHJpdmVycy9paW8vdGVtcGVyYXR1cmUvbWF4aW1fdGhlcm1vY291cGxlLmM6MTI4OjY6IG5v dGU6IOKAmHJldOKAmSB3YXMKPiBkZWNsYXJlZCBoZXJlCj4gICAgIGludCByZXQ7Cj4gICAgICAg ICBefn4KPiAKPiBhbmQgSSBndWVzcyB0aGF0IGNvZGUgY2FuIGp1c3QgaW5pdGlhbGl6ZSAncmV0 JyB0byAnLUVJTlZBTCcgb3IKPiBzb21ldGhpbmcgdG8ganVzdCBtYWtlIHRoZSB0aGVvcmV0aWNh bCAic29tZWhvdyB3ZSBoYWQgYSB3cm9uZwo+IGNoaXAtPnJlYWRfc2l6ZSIgY2FzZSBlcnJvciBv dXQgY2xlYW5seS4KClJpZ2h0LCB0aGF0IHdhcyBteSBjb25jbHVzaW9uIHRvby4gSSBzZW50IHRo ZSBidWdmaXggb24gT2N0IDI1CmZvciBsaW51eC1uZXh0IGJ1dCBpdCBkaWRuJ3QgbWFrZSBpdCBp biB1bnRpbCB0aGlzIE1vbmRheSwgYWZ0ZXIKeW91IHB1bGxlZCB0aGUgcGF0Y2ggdGhhdCBpbnRy b2R1Y2VkIGl0IG9uIE9jdCAyOS4KClRoZSBjb21taXQgaW4gc3RhZ2luZy10ZXN0aW5nIGlzCjMy Y2I3ZDI3ZTY1ZCAoImlpbzogbWF4aW1fdGhlcm1vY291cGxlOiBkZXRlY3QgaW52YWxpZCBzdG9y YWdlIHNpemUgaW4gcmVhZCgpIikKCkdyZWcgYW5kIEpvbmF0aGFuLCBJIHNlZSBub3cgdGhhdCB0 aGlzIGlzIHBhcnQgb2YgdGhlICdpaW8tZm9yLTQuMTBiJwpicmFuY2gsIHNvIEkgc3VzcGVjdCB5 b3Ugd2VyZSBub3QgcGxhbm5pbmcgdG8gc2VuZCB0aGlzIGJlZm9yZSB0aGUKbWVyZ2Ugd2luZG93 LiBDb3VsZCB5b3UgbWFrZSBzdXJlIHRoaXMgZW5kcyB1cCBpbiB2NC45IHNvIHdlIGdldAphIGNs ZWFuIGJ1aWxkIHdoZW4gLVdtYXliZS11bmluaXRpYWxpemVkIGdldHMgZW5hYmxlZCBhZ2Fpbj8K CglBcm5kCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1zbnBzLWFyYyBtYWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNu cHMtYXJj From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 11 Nov 2016 20:49:48 +0100 Subject: [PATCH v2 00/11] getting back -Wmaybe-uninitialized In-Reply-To: References: <20161110164454.293477-1-arnd@arndb.de> List-ID: Message-ID: <2695221.kyRJMsRMjs@wuerfel> To: linux-snps-arc@lists.infradead.org On Friday, November 11, 2016 9:13:00 AM CET Linus Torvalds wrote: > On Thu, Nov 10, 2016@8:44 AM, Arnd Bergmann wrote: > > > > Please merge these directly if you are happy with the result. > > I will take this. Thanks a lot! > I do see two warnings, but they both seem to be valid and recent, > though, so I have no issues with the spurious cases. Ok, both of them should have my fixes coming your way already. > Warning #1: > > sound/soc/qcom/lpass-platform.c: In function ?lpass_platform_pcmops_open?: > sound/soc/qcom/lpass-platform.c:83:29: warning: ?dma_ch? may be used > uninitialized in this function [-Wmaybe-uninitialized] > drvdata->substream[dma_ch] = substream; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ > > and 'dma_ch' usage there really is crazy and wrong. Broken by > 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Right, the patches crossed here, the bugfix patch that introduced this came into linux-next over the kernel summit, and the fix I sent on Tuesday made it into Mark Brown's tree on Wednesday but not before you pulled alsa tree. It should be fixed the next time you pull from the alsa tree, the commit is 3b89e4b77ef9 ("ASoC: lpass-platform: initialize dma channel number") > Warning #2 is not a real bug, but it's reasonable that gcc doesn't > know that storage_bytes (chip->read_size) has to be 2/4. Again, > introduced recently by commit 231147ee77f3 ("iio: maxim_thermocouple: > Align 16 bit big endian value of raw reads"), so you didn't see it. This is the one I mentioned in the commit message as one that is fixed in linux-next and that should make it in soon. > drivers/iio/temperature/maxim_thermocouple.c: In function > ?maxim_thermocouple_read_raw?: > drivers/iio/temperature/maxim_thermocouple.c:141:5: warning: ?ret? > may be used uninitialized in this function [-Wmaybe-uninitialized] > if (ret) > ^ > drivers/iio/temperature/maxim_thermocouple.c:128:6: note: ?ret? was > declared here > int ret; > ^~~ > > and I guess that code can just initialize 'ret' to '-EINVAL' or > something to just make the theoretical "somehow we had a wrong > chip->read_size" case error out cleanly. Right, that was my conclusion too. I sent the bugfix on Oct 25 for linux-next but it didn't make it in until this Monday, after you pulled the patch that introduced it on Oct 29. The commit in staging-testing is 32cb7d27e65d ("iio: maxim_thermocouple: detect invalid storage size in read()") Greg and Jonathan, I see now that this is part of the 'iio-for-4.10b' branch, so I suspect you were not planning to send this before the merge window. Could you make sure this ends up in v4.9 so we get a clean build when -Wmaybe-uninitialized gets enabled again? Arnd