Re: [PATCH v6 08/19] hw/i386/pc_piix.c: remove nvdimm initialisation from pc_init_isa()

[Xiaoyao Li <xiaoyao.li@intel.com>]

On 8/22/2025 8:11 PM, Mark Cave-Ayland wrote:
> NVDIMMs cannot be used by PCs from a pre-PCI era.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

> ---
>   hw/i386/pc_piix.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 129a3e2524..816124c027 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -592,12 +592,6 @@ static void pc_init_isa(MachineState *machine)
>           }
>       }
>   #endif
> -
> -    if (machine->nvdimms_state->is_enabled) {
> -        nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
> -                               x86_nvdimm_acpi_dsmio,
> -                               x86ms->fw_cfg, OBJECT(pcms));
> -    }
>   }
>   #endif
>