Re: [PATCH] devtools: add script to get maintainers from patch

[Thomas Monjalon <thomas@monjalon.net>]

Hi,

Sorry for looking at it just now.

28/04/2017 18:34, Ferruh Yigit:
> This is a wrapper to Linux kernel get_maintainer.pl file and only
> supports parsing MAINTAINERS file (no git fallback etc..)

That's the reason the same file format was used in DPDK ;)

> Requires DPDK_GETMAINTAINER_PATH devel config option set, please check
> devtools/load-devel-config.
> 
> DPDK_GETMAINTAINER_PATH should be full patch to the get_maintainer.pl
> script, like:
> DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl
> 
> Can be used individually:
> ./devtools/get_maintainer.sh <my.patch>
> 
> Or via git send-email, to add maintainers automatically:
> git send-email --to-cmd ./devtools/get_maintainer.sh \
> --cc dev@dpdk.org HEAD -4

Please, could you update the contributor's guide?

> Currently there is an ugly workaround to be able to use Linux script out
> of the kernel tree, later better method can replace it.

Yes it is very ugly :/
Could you try to send a patch to Linux to avoid such workaround?
If we need to keep this workaround, we should at least make sure
the files are always well removed, thanks to a trap invocation.
[...]
> +workaround
> +$DPDK_GETMAINTAINER_PATH $options $@
> +fix_workaround

Please check how trap is used in devtools/test-build.sh
Thanks