From: Segher Boessenkool <segher@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v4]: Fix e500 v2 core reboot bug
Date: Wed, 13 Jun 2007 09:54:43 +0200 [thread overview]
Message-ID: <26a24ad5f123db79f880f8c53cf2c71f@kernel.crashing.org> (raw)
In-Reply-To: <1181720633.12936.19.camel@localhost.localdomain>
>> There is no real reason to break the string in two anyway, it
>> is fine to have a more-than-80-char line in printk messages.
>>
> I separate it, because I am afraid I will be challenged by 80 char
> column rule.
Yeah, I understand.
> Please check the CodeStyle file and its example:
[snip]
> If it does not matter, I'd like to put them in one line :-).
Current thinking on this seems to be that long literal strings
are fine. You are right that some people might challenge you
on this, of course ;-)
Segher
next prev parent reply other threads:[~2007-06-13 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 6:53 [PATCH v4]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-06-13 7:03 ` Segher Boessenkool
2007-06-13 7:14 ` Zang Roy-r61911
2007-06-13 7:26 ` Segher Boessenkool
2007-06-13 7:43 ` Zang Roy-r61911
2007-06-13 7:49 ` Li Yang-r58472
2007-06-13 7:55 ` Segher Boessenkool
2007-06-13 8:07 ` Zang Roy-r61911
2007-06-13 8:16 ` Li Yang-r58472
2007-06-13 9:13 ` Zang Roy-r61911
2007-06-14 13:26 ` Kumar Gala
2007-06-13 7:54 ` Segher Boessenkool [this message]
2007-06-13 8:27 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a24ad5f123db79f880f8c53cf2c71f@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.