From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: linux-xfs@vger.kernel.org
Cc: "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH] xfs: correct calculation for blockcount
Date: Fri, 8 Sep 2023 18:18:52 +0800 [thread overview]
Message-ID: <26b057ea-c373-4df5-9d7e-cf56d78844a5@fujitsu.com> (raw)
In-Reply-To: <20230828072450.1510248-1-ruansy.fnst@fujitsu.com>
Ping~
在 2023/8/28 15:24, Shiyang Ruan 写道:
> The blockcount, which means length, should be "end + 1 - start". So,
> add the missing "+1" here.
>
> Fixes: 5cf32f63b0f4 ("xfs: fix the calculation for "end" and "length"")
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> ---
> fs/xfs/xfs_notify_failure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c
> index 4a9bbd3fe120..459fc8a39635 100644
> --- a/fs/xfs/xfs_notify_failure.c
> +++ b/fs/xfs/xfs_notify_failure.c
> @@ -151,7 +151,7 @@ xfs_dax_notify_ddev_failure(
> agend = min(be32_to_cpu(agf->agf_length),
> ri_high.rm_startblock);
> notify.startblock = ri_low.rm_startblock;
> - notify.blockcount = agend - ri_low.rm_startblock;
> + notify.blockcount = agend + 1 - ri_low.rm_startblock;
>
> error = xfs_rmap_query_range(cur, &ri_low, &ri_high,
> xfs_dax_failure_fn, ¬ify);
next prev parent reply other threads:[~2023-09-08 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:24 [PATCH] xfs: correct calculation for blockcount Shiyang Ruan
2023-09-08 10:18 ` Shiyang Ruan [this message]
2023-09-08 23:55 ` Darrick J. Wong
2023-09-11 10:47 ` Shiyang Ruan
2023-09-11 10:46 ` [PATCH v2] xfs: correct calculation for agend and blockcount Shiyang Ruan
2023-09-12 1:00 ` Darrick J. Wong
2023-09-13 10:29 ` [PATCH v3] " Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26b057ea-c373-4df5-9d7e-cf56d78844a5@fujitsu.com \
--to=ruansy.fnst@fujitsu.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.