From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F4DC43217 for ; Tue, 17 May 2022 09:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244092AbiEQJE5 (ORCPT ); Tue, 17 May 2022 05:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243998AbiEQJEw (ORCPT ); Tue, 17 May 2022 05:04:52 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9EF53F889; Tue, 17 May 2022 02:04:45 -0700 (PDT) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24H8cxGM032682; Tue, 17 May 2022 09:04:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ICKLJGaM1VvTpfQYzA/JpJ+aToE0/fQmHfd7Tob/YX8=; b=JAZyRGtloq8IJfau9sm0rW6nHIbqiVYUUfk5Vmoprn1c5UepLq68nXLWPPe3rpOBjpKd GtzEhTMBSs4WTF1nerBSQzLym4dV2Qa5pV+FnvVr+mJjIJCTG13Fy/eysdKvVUj9wnvz vfENarXAOjRAkdj98eTXYXHugSSK5cKD3/eayJPHOO8ygROfrdWcLQJw5g2NkS1UuCmH Z2qcAv1/ezSoqRD+3NzphC76FCznZ5OWFEGryRVrTwxNrBMqMU+6oDO1lQfU5Ci4fyy9 ATYHXjVwmGYS58xQ5dSMs+9j4j81Aizp3a5zAdMbZjfpzjd21HFJg/0MWSJ0lFM6/jbl 0g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g47tv1872-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 09:04:44 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24H8vRWV013967; Tue, 17 May 2022 09:04:44 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g47tv186d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 09:04:44 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24H91sNx020003; Tue, 17 May 2022 09:04:42 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3g23pjbx2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 09:04:42 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24H94c7K13762894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 May 2022 09:04:38 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91734A4051; Tue, 17 May 2022 09:04:38 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AB54A404D; Tue, 17 May 2022 09:04:38 +0000 (GMT) Received: from [9.152.224.153] (unknown [9.152.224.153]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 May 2022 09:04:38 +0000 (GMT) Message-ID: <26b55ac4-2acc-b9c7-a999-50a79d56a2de@linux.ibm.com> Date: Tue, 17 May 2022 11:04:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [kvm-unit-tests PATCH 3/6] s390x: uv-host: Test uv immediate parameter Content-Language: en-US To: Janosch Frank , kvm390 mailing list Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, thuth@redhat.com, nrb@linux.ibm.com, scgl@linux.ibm.com References: <20220513095017.16301-1-frankja@linux.ibm.com> <20220513095017.16301-4-frankja@linux.ibm.com> <8c852bcd-6b42-4b54-d3ff-5d63a389b05d@linux.ibm.com> <719224db-3a24-d38f-6678-2d3f08963ac0@linux.ibm.com> From: Steffen Eiden Organization: IBM In-Reply-To: <719224db-3a24-d38f-6678-2d3f08963ac0@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 7MmfdQRU73iKIqFMdQbEH5kGNLZwwxpq X-Proofpoint-ORIG-GUID: jK8lc0OTA-hnVrQOh-N6IKYDpv3S5TpZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-17_01,2022-05-16_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205170055 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 5/17/22 11:03, Janosch Frank wrote: > On 5/17/22 10:29, Steffen Eiden wrote: >> Hey Janosch, >> >> On 5/13/22 11:50, Janosch Frank wrote: >>> Let's check if we get a specification PGM exception if we set a >>> non-zero i3 when doing a UV call. >>> >>> Signed-off-by: Janosch Frank >>> --- >>>    s390x/uv-host.c | 23 +++++++++++++++++++++++ >>>    1 file changed, 23 insertions(+) >>> >>> diff --git a/s390x/uv-host.c b/s390x/uv-host.c >>> index f846fc42..fcb82d24 100644 >>> --- a/s390x/uv-host.c >>> +++ b/s390x/uv-host.c >>> @@ -64,6 +64,28 @@ static struct cmd_list cmds[] = { >>>        { NULL, 0, 0 }, >>>    }; >>> +static void test_i3(void) >>> +{ >>> +    struct uv_cb_header uvcb = { >>> +        .cmd = UVC_CMD_INIT_UV, >>> +        .len = sizeof(struct uv_cb_init), >>> +    }; >>> +    unsigned long r1 = 0; >> Did you forgot 'r2' or is it missing for a reason? > > The uvcb is the r2, have a look at the clobbers below Oh right, my bad; Sorry. > >> >>> +    int cc; >>> + >>> +    report_prefix_push("i3"); >>> +    expect_pgm_int(); >>> +    asm volatile( >>> +        "0:    .insn rrf,0xB9A40000,%[r1],%[r2],4,2\n" >>> +        "        ipm    %[cc]\n" >>> +        "        srl    %[cc],28\n" >>> +        : [cc] "=d" (cc) >>> +        : [r1] "a" (r1), [r2] "a" (&uvcb) >>> +        : "memory", "cc"); >>> +    check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); >>> +    report_prefix_pop(); >>> +} >>> + >>>    static void test_priv(void) >>>    { >>>        struct uv_cb_header uvcb = {}; >>> @@ -585,6 +607,7 @@ int main(void) >>>            goto done; >>>        } >>> +    test_i3(); >>>        test_priv(); >>>        test_invalid(); >>>        test_uv_uninitialized(); > -- Reviewed-by: Steffen Eiden