From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83D26CA0FFE for ; Tue, 2 Sep 2025 11:27:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 447254192B; Tue, 2 Sep 2025 11:27:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kfwfV5BukO7E; Tue, 2 Sep 2025 11:27:37 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B0DF841A2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756812457; bh=KjuMAF6x2C7Y8qlg9yXCuClA+VXqEPKyCJn/KO2TycM=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RGlx97tYyg+nXEAMIG/QbxMrbvftw63G04GQEt9+T+N32xdYMkYj30SXm5GP2riTo etkcxhG9goP6r3AfAfmoFerE8jDfbou7GxJxuEVwhFrK7pSdPBq84CUnJnhdS3Z5Ow 1gKpmP8T6XbycAtxIPCemYyLzx4h73kB7yV3J/rO/IJa2vQGfQ+Eq1vHuP9cViw1Gh WzKi0vvc9G1y8z/mO4oHudEAp5G7enR1pTyeDhM5gRvVDq0nTT+PpnfgqR/JnsYGAh P0IJqYKvMcFRgRIyXEmVXQwC8WOjHDGse5DxkLM+nIPgLobRqY92c8oJUSW81gnTL/ jcStjwCLyc5Ow== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id B0DF841A2C; Tue, 2 Sep 2025 11:27:37 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 72836439 for ; Tue, 2 Sep 2025 11:27:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6AA1241A2C for ; Tue, 2 Sep 2025 11:27:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ZtQYWVxNJdQ3 for ; Tue, 2 Sep 2025 11:27:36 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:41d0:1004:224b::bc; helo=out-188.mta0.migadu.com; envelope-from=vadim.fedorenko@linux.dev; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org B1C5F4192B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B1C5F4192B Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [IPv6:2001:41d0:1004:224b::bc]) by smtp4.osuosl.org (Postfix) with ESMTPS id B1C5F4192B for ; Tue, 2 Sep 2025 11:27:35 +0000 (UTC) Message-ID: <26c0cd9c-ad24-4b71-9a1a-d046b94d9333@linux.dev> Date: Tue, 2 Sep 2025 12:27:29 +0100 MIME-Version: 1.0 To: Anton Nadezhdin , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, richardcochran@gmail.com, Milena Olech , Aleksandr Loktionov , Jakub Kicinski , Willem de Bruijn References: <20250902105321.5750-1-anton.nadezhdin@intel.com> <20250902105321.5750-3-anton.nadezhdin@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902105321.5750-3-anton.nadezhdin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756812452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjuMAF6x2C7Y8qlg9yXCuClA+VXqEPKyCJn/KO2TycM=; b=xCx54zKiy5JYlY4xA0reccCPyd3bSu+DqnFgijhn3sU3m6TiLAn7WqXLEDj/KMNDnPbQi2 3Jc4V0EcRGg4a7F+5NdGzv+TxF+Ty7FmVJuPiVwZ025yzb0yNpRv6teShuq+i+4vCzx5c4 X/QcOQJGrVIoi+WMLcvUj1LPC8skWtg= X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linux.dev X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=xCx54zKi Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/2] idpf: add direct method for disciplining Tx timestamping X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 02/09/2025 11:50, Anton Nadezhdin wrote: > From: Milena Olech > > Currently IDPF supports only mailbox access to PHC operations and > Tx timestamping, however the driver shall also be able to handle direct > access. The difference is that PHC/timestamps actions are performed > directly, through BAR registers, instead of sending a virtchnl message to > CP. Registers offsets are negotiated with the CP during the capabilities > negotiation. > > Signed-off-by: Milena Olech > Co-developed-by: Anton Nadezhdin > Signed-off-by: Anton Nadezhdin > Reviewed-by: Aleksandr Loktionov [...] > -static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb) > +static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb, > + u32 buf_id) > { > struct idpf_ptp_vport_tx_tstamp_caps *tx_tstamp_caps; > - struct idpf_ptp_tx_tstamp_status *tx_tstamp_status; > + struct idpf_ptp_tx_tstamp_status *tx_tstamp_status = NULL; this breaks reverse x-mass tree aligment... > + enum idpf_ptp_access access; > + int err; From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822B02ED870 for ; Tue, 2 Sep 2025 11:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756812456; cv=none; b=eIOc7feo96mCCWPGbFby603dJS631UYGUoisKlraE0O42JHck8WS61zxXFXjBgMez2Wm9ax/Uf61/NMMyvkPI9i7Vy7tID0qREjURyKrrQkPrDDZ6SNGgKpLX+H16N+AHOiUAib+zFyi0ImQUQpU4jlhvvQHbhNOs47dB+BmDqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756812456; c=relaxed/simple; bh=/JXOjGh4jT/TCQiLeH7evpZHmaOgNXOxW1XjD/YXOxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PKot+JnZN8XAlkfRmZWrqmSpPM3OuJCLdTvqhIDOJukc2PwC0pO1uT5/kIW+jIM9zQs8VS6Qo473QdKD2s2ejluf50sIREa2Ut+RjQFT8Rbk/on9o94NZr3yaFH99+nr8JMv3GpFDQBlOtZRyO5tk46bdc1pLYPypm05ITI/Uog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xCx54zKi; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xCx54zKi" Message-ID: <26c0cd9c-ad24-4b71-9a1a-d046b94d9333@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756812452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjuMAF6x2C7Y8qlg9yXCuClA+VXqEPKyCJn/KO2TycM=; b=xCx54zKiy5JYlY4xA0reccCPyd3bSu+DqnFgijhn3sU3m6TiLAn7WqXLEDj/KMNDnPbQi2 3Jc4V0EcRGg4a7F+5NdGzv+TxF+Ty7FmVJuPiVwZ025yzb0yNpRv6teShuq+i+4vCzx5c4 X/QcOQJGrVIoi+WMLcvUj1LPC8skWtg= Date: Tue, 2 Sep 2025 12:27:29 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH iwl-next 2/2] idpf: add direct method for disciplining Tx timestamping To: Anton Nadezhdin , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, richardcochran@gmail.com, Milena Olech , Aleksandr Loktionov , Jakub Kicinski , Willem de Bruijn References: <20250902105321.5750-1-anton.nadezhdin@intel.com> <20250902105321.5750-3-anton.nadezhdin@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902105321.5750-3-anton.nadezhdin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 02/09/2025 11:50, Anton Nadezhdin wrote: > From: Milena Olech > > Currently IDPF supports only mailbox access to PHC operations and > Tx timestamping, however the driver shall also be able to handle direct > access. The difference is that PHC/timestamps actions are performed > directly, through BAR registers, instead of sending a virtchnl message to > CP. Registers offsets are negotiated with the CP during the capabilities > negotiation. > > Signed-off-by: Milena Olech > Co-developed-by: Anton Nadezhdin > Signed-off-by: Anton Nadezhdin > Reviewed-by: Aleksandr Loktionov [...] > -static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb) > +static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb, > + u32 buf_id) > { > struct idpf_ptp_vport_tx_tstamp_caps *tx_tstamp_caps; > - struct idpf_ptp_tx_tstamp_status *tx_tstamp_status; > + struct idpf_ptp_tx_tstamp_status *tx_tstamp_status = NULL; this breaks reverse x-mass tree aligment... > + enum idpf_ptp_access access; > + int err;