All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] correct disabling of -Wshift-negative-value
Date: Tue, 15 Apr 2025 07:53:12 +0200	[thread overview]
Message-ID: <26dcdba6-1aae-4a5c-bd64-78406b7f39b9@suse.com> (raw)
In-Reply-To: <20250414193836.GA107755@ax162>

On 14.04.2025 21:38, Nathan Chancellor wrote:
> On Mon, Apr 14, 2025 at 04:23:36PM +0200, Jan Beulich wrote:
>> The warning is supported only from gcc6 onwards, hence its disabling
>> needs probing that the (positive) option is actually supported.
>>
>> Fixes: 1344794a59db ("Kbuild: add -Wno-shift-negative-value where -Wextra is used")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> The patch itself seems fine (I might add "scripts/Makefile.extrawarn: "
> to the title) but if I understand correctly, this is only to support GCC
> 5? Would this be necessary if GCC 8.1 becomes the minimum supported
> version of GCC for building the kernel?
> 
> https://lore.kernel.org/20250407094116.1339199-2-arnd@kernel.org/
> 
> If people are actively noticing this, perhaps we should send this to
> Linus's tree for backports then Arnd could revert it in his series?

Actually, aiui that work was meanwhile merged. Hence the patch here is
indeed only applicable to stable trees. No idea how such a situation
is to be handled. (Apparently the same is true for "correct disabling
of -Wstringop-overflow": That option was introduced in gcc7.)

Jan

  reply	other threads:[~2025-04-15  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 14:23 [PATCH] correct disabling of -Wshift-negative-value Jan Beulich
2025-04-14 19:38 ` Nathan Chancellor
2025-04-15  5:53   ` Jan Beulich [this message]
2025-04-15 21:15     ` Nathan Chancellor
2025-04-16  6:07       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26dcdba6-1aae-4a5c-bd64-78406b7f39b9@suse.com \
    --to=jbeulich@suse.com \
    --cc=arnd@arndb.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.