From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF08C43334 for ; Tue, 19 Jul 2022 14:26:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 01B1A16D1; Tue, 19 Jul 2022 16:25:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 01B1A16D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1658240761; bh=QymwNLTw+r+SLmXB6/1tpXs8q8Yf+hUenOyUMN0/wGM=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Xij2sAQaG2EKyal+bBuz3ODJ2kvTEqCZJeJcwlTF7LBi42kt7nfzCI/mprZfokahS nc7sPc+N6icZBm3vLmkAV0bwK5iSDUeTjR9KNlfjGJnTqRjs36U6Go0sfqAM2WzkeB vYqYzOpoefOT/EYr84rjStOEFFUNEcEclX74/2gw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9A3F7F80118; Tue, 19 Jul 2022 16:25:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE90CF80125; Tue, 19 Jul 2022 16:25:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 39804F80125 for ; Tue, 19 Jul 2022 16:25:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 39804F80125 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lpARN0Ic" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658240704; x=1689776704; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QymwNLTw+r+SLmXB6/1tpXs8q8Yf+hUenOyUMN0/wGM=; b=lpARN0IcezvB1twzlXSRnThklkDByTPvTEXLaGCbTBqduOArzpvieCWX fFZvUNTF5i9t+gsn+xGdNtvvj/3wJcqxdlkS3Zu8Tb/ltSBCWsCeOMOcF 1ga1ayWgai2OQEnb5gPFv+nZar1cqzJGhWiFv6M5tBZ6cuP9FxSwkCwi8 i3dPeWyZiNEZBBSJOfVvb6HtNeMLwQ5i3DyuYEIISS8bOMOlP6iZc8lFv r7E6bOjOOouq9zPjc08LT5DrpE3/BU6/K/HKnyZO5+EHI8Ftq3Kag5rd5 iZt61J0EwY3gMeOV9o1oyo2h9Qge+grIcbd01z2OSSum+OZyvcsfahFq/ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="372805214" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="372805214" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:24:58 -0700 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="594845495" Received: from kckollur-mobl1.amr.corp.intel.com (HELO [10.212.118.182]) ([10.212.118.182]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:24:56 -0700 Message-ID: <26e40344-453f-6bdb-cd4b-15431a930497@linux.intel.com> Date: Tue, 19 Jul 2022 09:24:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH -next v2] ASoC: Intel: Fix missing clk_disable_unprepare() on err in platform_clock_control() Content-Language: en-US To: Zhang Zekun , cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, ALSA Development Mailing List , Mark Brown , Takashi Iwai , Hans de Goede References: <20220719013628.40153-1-zhangzekun11@huawei.com> From: Pierre-Louis Bossart In-Reply-To: <20220719013628.40153-1-zhangzekun11@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: xuqiang36@huawei.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/18/22 20:36, Zhang Zekun wrote: > Fix the missing clk_disable_unprepare() before return > from platform_clock_control() in error handling path. > > Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") > Signed-off-by: Zhang Zekun > --- > sound/soc/intel/boards/bytcr_wm5102.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c > index 45a6805787f5..3e3cdee4b1ce 100644 > --- a/sound/soc/intel/boards/bytcr_wm5102.c > +++ b/sound/soc/intel/boards/bytcr_wm5102.c > @@ -111,6 +111,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w, > ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); > if (ret) { > dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); > + clk_disable_unprepare(priv->mclk); This change looks legit to me, but you want to CC: maintainers (Mark Brown, Takashi Iwai), use the alsa-devel mailing list and CC: the initial contributor Hans de Goede. > return ret; > } > } else { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2EF1C43334 for ; Tue, 19 Jul 2022 14:34:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237495AbiGSOeY (ORCPT ); Tue, 19 Jul 2022 10:34:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239025AbiGSOeE (ORCPT ); Tue, 19 Jul 2022 10:34:04 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03BD3263C for ; Tue, 19 Jul 2022 07:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658240697; x=1689776697; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QymwNLTw+r+SLmXB6/1tpXs8q8Yf+hUenOyUMN0/wGM=; b=U7jmdEvcDiqW4FKLf1KoUp07zirX1+sSX6ZqrnXzOHPmwyUx3u3hLqNp wJHvLBh4lhcqzk6t1a9PPQ5Fjh67ZJKxlNfDEBxL6O2thfBRRUjYBDsEl UhggRj/XciCMsNWZYEvxbSYq3iCCt2g5Nz/VpzGwOw3qEoJVAuwjq9ItK zlNRGKro1kWLYCqMaTYZzdJgaSTetVsc7yEVwTXVvssksP1N4iZndJubW kEKjLQ9bDvb5gDs3nbnL+x5ONhnEBdWvbuAFuCo5XpFNnEfkqffaYLfI/ 2SKKJjeq5XJtEqeDAgYVRxqCbgdH0xQEVrw0R1KIGMBkkHEykvESC9Dsu Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="312192946" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="312192946" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:24:57 -0700 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="594845495" Received: from kckollur-mobl1.amr.corp.intel.com (HELO [10.212.118.182]) ([10.212.118.182]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:24:56 -0700 Message-ID: <26e40344-453f-6bdb-cd4b-15431a930497@linux.intel.com> Date: Tue, 19 Jul 2022 09:24:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH -next v2] ASoC: Intel: Fix missing clk_disable_unprepare() on err in platform_clock_control() Content-Language: en-US To: Zhang Zekun , cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, ALSA Development Mailing List , Mark Brown , Takashi Iwai , Hans de Goede Cc: linux-kernel@vger.kernel.org, xuqiang36@huawei.com References: <20220719013628.40153-1-zhangzekun11@huawei.com> From: Pierre-Louis Bossart In-Reply-To: <20220719013628.40153-1-zhangzekun11@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/22 20:36, Zhang Zekun wrote: > Fix the missing clk_disable_unprepare() before return > from platform_clock_control() in error handling path. > > Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") > Signed-off-by: Zhang Zekun > --- > sound/soc/intel/boards/bytcr_wm5102.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c > index 45a6805787f5..3e3cdee4b1ce 100644 > --- a/sound/soc/intel/boards/bytcr_wm5102.c > +++ b/sound/soc/intel/boards/bytcr_wm5102.c > @@ -111,6 +111,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w, > ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); > if (ret) { > dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); > + clk_disable_unprepare(priv->mclk); This change looks legit to me, but you want to CC: maintainers (Mark Brown, Takashi Iwai), use the alsa-devel mailing list and CC: the initial contributor Hans de Goede. > return ret; > } > } else {