From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
"Kadam, Pallavi" <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix deadlock when setting alarm
Date: Tue, 03 Nov 2020 21:32:20 +0100 [thread overview]
Message-ID: <2702203.uBd2FyOzSN@thomas> (raw)
In-Reply-To: <8f20cf1a-0302-cba6-58e7-6480a1ea638a@intel.com>
30/10/2020 20:25, Kadam, Pallavi:
> On 10/30/2020 11:42 AM, Dmitry Kozlyuk wrote:
> > Windows alarms are both armed and executed from the interrupt thread.
> > rte_eal_alarm_set() dispatched alarm-arming code to that thread and
> > waited for its completion via a spinlock. However, if called from alarm
> > callback (i.e. from the interrupt thread), this caused a deadlock,
> > because arming could not be run until its dispatcher exits, but it could
> > only exit after it finished waiting for arming to complete.
> >
> > Call arming code directly when running in the interrupt thread.
> >
> > Fixes: f4cbdbc7fbd2 ("eal/windows: implement alarm API")
> >
> > Reported-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
>
> Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
>
> Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-11-03 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 18:31 [dpdk-dev] [PATCH] eal/windows: fix deadlock when setting alarm Dmitry Kozlyuk
2020-10-30 18:42 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2020-10-30 19:25 ` Kadam, Pallavi
2020-11-03 20:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2702203.uBd2FyOzSN@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.