Re: [PATCH v5 1/8]i40e:support VxLAN packet identification in librte_ether

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-10-11 13:55, Jijiang Liu:
> Add data structures and APIs in librte_ether for supporting tunneling UDP port configuration on i40e,
> Currently, only VxLAN is implemented, which include
>  -  VxLAN UDP port initialization
>  -  Add APIs to configure VxLAN UDP port

Please could you explain in the commit log how it is related to filtering?

[...]

> + /**
> + * Add tunneling UDP port configuration of Ethernet device

tunneling UDP or UDP tunneling?

Please, explain what the device could do with these informations.
Offloading? Filtering?

> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + * @param tunnel_udp
> + *   Where to store the current Tunneling UDP configuration
> + *   of the Ethernet device.

Many words are useless here.
"UDP tunneling configuration" should be sufficient.

> + * @param count
> + *   How many configurations are going to added.

It's a verbose commenting style, but why not.
Typo: "to be added".

> + *
> + * @return
> + *   - (0) if successful.
> + *   - (-ENODEV) if port identifier is invalid.
> + *   - (-ENOTSUP) if hardware doesn't support tunnel type.
> + */
> +int
> +rte_eth_dev_udp_tunnel_add(uint8_t port_id,
> +			struct rte_eth_udp_tunnel *tunnel_udp,
> +			uint8_t count);

Thanks
-- 
Thomas