From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/3] input: evdev: add new ioctl EVIOCSIFTYPE / EVIOCGIFTYPE Date: Fri, 27 Nov 2015 17:59:04 +0100 Message-ID: <2705528.qSj27KAuDS@wuerfel> References: <1448618432-32357-1-git-send-email-pingbo.wen@linaro.org> <1448618432-32357-3-git-send-email-pingbo.wen@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1448618432-32357-3-git-send-email-pingbo.wen@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: WEN Pingbo Cc: y2038@lists.linaro.org, linux-api@vger.kernel.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, aksgarg1989@gmail.com, linux-input@vger.kernel.org List-Id: linux-api@vger.kernel.org T24gRnJpZGF5IDI3IE5vdmVtYmVyIDIwMTUgMTg6MDA6MzEgV0VOIFBpbmdibyB3cm90ZToKPiBU aGlzIHBhdGNoIGRlcGVuZHMgb24gJ2ludHJvZHVjZSBuZXcgZXZkZXYgaW50ZXJmYWNlJy4KPiAK PiBVc2Vyc3BhY2UgY2F0IHNldCAvIGdldCBldmRldiBpbnRlcmZhY2UgdHlwZSB2aWEgdGhlIHR3 byBpb2N0bAo+IGNvbW1hbmRzLiBBbmQgZGVmYXVsdCBpbnRlcmZhY2UgdHlwZSBpcyBFVl9JRl9M RUdBQ1ksIHNvIHRoZSBvbGQgYmluYXJ5Cj4gd2lsbCB3b3JrIG5vcm1hbCB3aXRoIG5ldyBrZXJu ZWwuIE1heWJlIHdlIHNob3VsZCBjaGFuZ2UgdGhpcyBkZWZhdWx0Cj4gb3B0aW9uIHRvIGVuY291 cmFnZSBwZW9wbGUgdG8gbW92ZSB0byBuZXcgaW50ZXJmYWNlLgo+IAo+IEFuZCBzaW5jZSBhbGwg ZXZlbnRzIGFyZSBzdG9yZWQgYXMgaW5wdXRfdmFsdWUgaW4gZXZkZXYsIHRoZXJlIGFyZSBubwo+ IG5lZWQgdG8gZmx1c2ggZXZkZXZfY2xpZW50J3MgYnVmZmVyIGlmIHdlIGNoYW5nZSBjbGtfdHlw ZSBhbmQgaWZfdHlwZS4KCkkgd291bGQgc3BsaXQgb3V0IHRoZSBjaGFuZ2UgdG8gZXZkZXZfc2V0 X2Nsa190eXBlIGludG8gYSBzZXBhcmF0ZSBwYXRjaC4KCj4gKwljYXNlIEVWSU9DU0lGVFlQRToK PiArCQlpZiAoZ2V0X3VzZXIoaWZfdHlwZSwgaXApKQo+ICsJCQlyZXR1cm4gLUVGQVVMVDsKPiAr Cj4gKwkJcmV0dXJuIGV2ZGV2X3NldF9pZl90eXBlKGNsaWVudCwgaWZfdHlwZSk7Cj4gKwljYXNl IEVWSU9DR0lGVFlQRToKPiArCQlyZXR1cm4gcHV0X3VzZXIoY2xpZW50LT5pZl90eXBlLCBpcCk7 Cj4gIAl9CgpUaGlzIGxvb2sgYXN5bW1ldHJpYzogRVZJT0NTSUZUWVBFIHVzZXMgYSBFVkRFVl8q IGNvbnN0YW50LCB3aGlsZQpFVklPQ0dJRlRZUEUgcmV0dXJucyBhIEVWX0lGXyogY29uc3RhbnQu IFNob3VsZCB0aG9zZSBqdXN0CmJlIHRoZSBzYW1lIGNvbnN0YW50cyBhbnl3YXk/CgoJQXJuZApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpZMjAzOCBtYWls aW5nIGxpc3QKWTIwMzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxpbmFyby5vcmcv bWFpbG1hbi9saXN0aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754923AbbK0Q7N (ORCPT ); Fri, 27 Nov 2015 11:59:13 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:55704 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbbK0Q7J (ORCPT ); Fri, 27 Nov 2015 11:59:09 -0500 From: Arnd Bergmann To: WEN Pingbo Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com, aksgarg1989@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 2/3] input: evdev: add new ioctl EVIOCSIFTYPE / EVIOCGIFTYPE Date: Fri, 27 Nov 2015 17:59:04 +0100 Message-ID: <2705528.qSj27KAuDS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1448618432-32357-3-git-send-email-pingbo.wen@linaro.org> References: <1448618432-32357-1-git-send-email-pingbo.wen@linaro.org> <1448618432-32357-3-git-send-email-pingbo.wen@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:hBzUXLdIdX5TZEsFFCAzj10MqOzKs3FL2HpDrV0zgk83yF58Ffo 1g3LzNo3kJZXeyBc2N8v1lVXZ9JZ0Sa3NnyEWg/EC91LOasK0AymVDuJlfnR6/SU7bxefst 3SbtrJp1byzl4F6FAQt/y7OnGMBHyvVA7sSAV1hsvnWbsxKnA14O/DdZrSMZzdwd9ybH/Pt ioSRpubzAoTch3ZH9VRww== X-UI-Out-Filterresults: notjunk:1;V01:K0:tq3StnPlvPM=:VtbJ+/oEcQAMny8MDVx1IK 7HM6dX1h3gADkWL6rcCVQ9fuM6dpVwp4GxNzt7p2/A+44Oe5+NAQSkj9Ts1IxnZ27BwNvxSP5 xsiUJeBmxV+9xeeDb5SLpXGmFWx0iqv9HchpzAblH3eMpLRa0vA/NXOSuAINCNaxNk09u37gV UEx6eNKxZd2Slq/owiJ9o/wxpPw4Asff+T8pTumOyL2nMhHrdQeLLVC9IBntzy/kf/ydbX1Wi Fh0pjDwWvIXUhL0zdzivxuAK7kFSaV+QnShyDDZRMLQ4RgfJVvWxdULeN641NwzcdfqyjC/6C J4pfacd0LaypkR3Dk39PvTJjLatr+CCQSZyynJoy7ADg5OrCYWdqL0cw72OkN6Y7iDrdr2Lbr jkAZXq20xrVOOcZ/DI7l8wf7PPpYquLTaIEJyvRwuN6uz54mthpkc1oPBuVdg06p/9htOZSrf sEQRwMsdcmM5JEqm8JML2z83KjuSXTrtgVkIjAiffV91fdImbeCvEv/N41+EVoyts2dzmohS+ xgg6Viw3TGh6XnASye67sZjH9Y7648CXb5gFgQH1orbCG/u6zECN0MjP+y6a53uZSzymD0SRN TDBSJiJ9YrrIrxgYaJY1I09bRZ8FDlqd4BWzOUVFAQVBz5EV1CLR2IU4IlWq4x7IZ2aoBzzi4 zrmBQxXI+5ctbc1s4D8odp8I157sRo95v6/JxT4RQlqcFUowWwWjj92/TtyM/d2oRMxcLpt2j Aeqgeh8p6QR7e6kc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 27 November 2015 18:00:31 WEN Pingbo wrote: > This patch depends on 'introduce new evdev interface'. > > Userspace cat set / get evdev interface type via the two ioctl > commands. And default interface type is EV_IF_LEGACY, so the old binary > will work normal with new kernel. Maybe we should change this default > option to encourage people to move to new interface. > > And since all events are stored as input_value in evdev, there are no > need to flush evdev_client's buffer if we change clk_type and if_type. I would split out the change to evdev_set_clk_type into a separate patch. > + case EVIOCSIFTYPE: > + if (get_user(if_type, ip)) > + return -EFAULT; > + > + return evdev_set_if_type(client, if_type); > + case EVIOCGIFTYPE: > + return put_user(client->if_type, ip); > } This look asymmetric: EVIOCSIFTYPE uses a EVDEV_* constant, while EVIOCGIFTYPE returns a EV_IF_* constant. Should those just be the same constants anyway? Arnd