Re: [PATCH v2] ALSA: sound/atmel/ac97c.c: Add device tree support

[Alexander Stein <alexanders83@web.de>]

On Wednesday 10 December 2014, 21:04:54 wrote Lars-Peter Clausen:
> On 12/10/2014 08:59 PM, Alexander Stein wrote:
> > This adds device tree support for the AC97 controller. It uses the
> > soc-ac97link bindings, but actually only ac97-reset is used.
> >
> > Signed-off-by: Alexander Stein <alexanders83@web.de>
> > ---
> > Changes in v2:
> > * It now uses the soc-ac97link bindings (partly) instead of defining its own.
> >    This should ease the transition to ASoC once a new driver has been written.
> 
> Partly? How do they differ? And why do they differ? The devicetree should 
> describe the hardware, which I guess is the same in both cases.

The devicetree is defined the same way, but not all set properties are used.
The soc-ac97link binding defines 3 GPIOs where 2 are used in conjunction with different pinctl modes for different reset modes.
The rather old atmel_ac97c driver only supports reset per Reset-GPIO which is the 3rd one given in devicetree. Because this driver only
uses the 3rd GPIO I've written 'partly'.

Best regards,
Alexander