All of lore.kernel.org
 help / color / mirror / Atom feed
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] USB: OHCI: Properly handle ohci-exynos suspend
Date: Wed, 02 Oct 2013 17:10:32 +0200	[thread overview]
Message-ID: <2706834.Eq1ry5ZFL1@amdc1032> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1310021036360.1293-100000@iolanthe.rowland.org>


Hi,

On Wednesday, October 02, 2013 10:38:58 AM Alan Stern wrote:
> On Wed, 2 Oct 2013, Bartlomiej Zolnierkiewicz wrote:
> 
> > Maybe it would make sense to cleanup ohci_suspend() first (before adding
> > new ohci_suspend() users) and remove unused do_wakeup parameter?
> 
> Not possible.  The do_wakeup parameter is part of a function prototype
> shared by other callback routines (such as ehci_suspend()) that _do_
> use the parameter.

If you mean ohci-pci.c usage (which is currently the only usage of
ohci_suspend() looking at the latest -next kernel) than it is enough
to add a simple wrapper for it in ohci-pci.c:

...
static int ohci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup)
{
	ohci_suspend(hcd);
}
...
    ohci_pci_hc_driver.pci_suspend = ohci_pci_suspend;
...


Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  reply	other threads:[~2013-10-02 15:10 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02 10:15 [PATCH 00/11] USB: OHCI:Properly handle ohci_suspend()routine in bus glue Majunath Goudar
2013-10-02 10:15 ` [PATCH 01/11] USB: OHCI: Properly handle OHCI controller suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 02/11] USB: OHCI: Properly handle ohci-at91 suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 03/11] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 04/11] USB: OHCI: Properly handle ohci-da8xx suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend Majunath Goudar
2013-10-14 15:49   ` Olof Johansson
2013-10-14 20:34     ` Alan Stern
2013-10-14 20:41       ` Greg KH
2013-10-14 20:42       ` Hartley Sweeten
2013-10-14 20:50         ` Alan Stern
2013-10-14 21:07           ` Hartley Sweeten
2013-10-15  4:32             ` Olof Johansson
     [not found]               ` <CAKsNYyzFe+o0ctNYyHhL7m71LnAC4WTKbkfN37WHmLBRjgj9+w@mail.gmail.com>
2013-10-15 15:15                 ` Greg KH
2013-10-02 10:15 ` [PATCH 06/11] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-02 11:34   ` Bartlomiej Zolnierkiewicz
2013-10-02 14:38     ` Alan Stern
2013-10-02 15:10       ` Bartlomiej Zolnierkiewicz [this message]
2013-10-02 15:52         ` Alan Stern
2013-10-02 10:15 ` [PATCH 07/11] USB: OHCI: Properly handle ohci-omap suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 08/11] USB: OHCI: Properly handle ohci-platform suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 09/11] USB: OHCI: Properly handle ohci-pxa27x suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 10/11] USB: OHCI: Properly handle ohci-sm501 suspend Majunath Goudar
2013-10-02 10:15 ` [PATCH 11/11] USB: OHCI: Properly handle ohci-spear suspend Majunath Goudar
2013-10-03 13:02 ` [PATCH V2 00/11] USB: OHCI :Properly handle ohci_suspend()routine in bus glue Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 01/11] USB: OHCI: Properly handle OHCI controller suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 02/11] USB: OHCI: Properly handle ohci-at91 suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 03/11] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 04/11] USB: OHCI: Properly handle ohci-da8xx suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 06/11] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 07/11] USB: OHCI: Properly handle ohci-omap suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 08/11] USB: OHCI: Properly handle ohci-platform suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 09/11] USB: OHCI: Properly handle ohci-pxa27x suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 10/11] USB: OHCI: Properly handle ohci-sm501 suspend Majunath Goudar
2013-10-03 13:02   ` [PATCH V2 11/11] USB: OHCI: Properly handle ohci-spear suspend Majunath Goudar
2013-10-15 13:19 ` [PATCH V2 0/7] USB: OHCI:Properly handle ohci_suspend()routine in bus glue Majunath Goudar
2013-10-15 13:19   ` [PATCH V2 1/7] USB: OHCI: Properly handle OHCI controller suspend Majunath Goudar
2013-10-15 15:19     ` Greg KH
2013-10-15 13:19   ` [PATCH V2 2/7] USB: OHCI: Properly handle ohci-at91 suspend Majunath Goudar
2013-10-15 13:19   ` [PATCH V2 3/7] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-15 13:19   ` [PATCH V2 4/7] USB: OHCI: Properly handle ohci-da8xx suspend Majunath Goudar
2013-10-15 13:20   ` [PATCH V2 5/7] USB: OHCI: Properly handle ohci-ep93xx suspend Majunath Goudar
2013-10-15 15:26     ` Alan Stern
2013-10-15 13:20   ` [PATCH V2 6/7] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-15 13:20   ` [PATCH V2 7/7] USB: OHCI: Properly handle ohci-spear suspend Majunath Goudar
     [not found] ` <1382016913-10872-1-git-send-email-csmanjuvijay@gmail.com>
2013-10-17 13:35   ` [PATCH V3 3/6] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-17 13:35     ` Majunath Goudar
2013-10-17 13:35   ` [PATCH V3 5/6] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-17 13:35     ` Majunath Goudar
     [not found] ` <1382094376-31016-1-git-send-email-csmanjuvijay@gmail.com>
2013-10-18 11:06   ` [PATCH V3 3/6] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-18 11:06     ` Majunath Goudar
2013-10-18 11:06   ` [PATCH V3 5/6] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-18 11:06     ` Majunath Goudar
     [not found] ` <1382365136-24472-1-git-send-email-csmanjuvijay@gmail.com>
2013-10-21 14:18   ` [PATCH V4 3/6] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-10-21 14:18     ` Majunath Goudar
2013-10-21 14:18   ` [PATCH V4 5/6] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-10-21 14:18     ` Majunath Goudar
2013-10-21 14:18     ` Majunath Goudar
2013-11-13 12:10 ` [PATCH V4 0/6]USB: OHCI:Properly handle ohci_suspend()routine in bus glue Majunath Goudar
2013-11-13 12:10   ` [PATCH V4 1/6] USB: OHCI: Properly handle OHCI controller suspend Majunath Goudar
2013-11-13 12:10   ` [PATCH 2/6] USB: OHCI: Properly handle ohci-at91 suspend Majunath Goudar
2013-11-13 12:10   ` [PATCH 3/6] USB: OHCI: Properly handle ohci-s3c2410 suspend Majunath Goudar
2013-11-13 12:10     ` Majunath Goudar
2013-11-13 12:10   ` [PATCH 4/6] USB: OHCI: Properly handle ohci-da8xx suspend Majunath Goudar
2013-11-13 12:10   ` [PATCH 5/6] USB: OHCI: Properly handle ohci-exynos suspend Majunath Goudar
2013-11-13 12:10     ` Majunath Goudar
2013-11-13 12:10   ` [PATCH 6/6] USB: OHCI: Properly handle ohci-spear suspend Majunath Goudar
     [not found] <CAKsNYyws1m1kT4KiJ6GFcTSo0cT=cu+0nA0vwx=wu_SuRhAfhA@mail.gmail.com>
2013-10-03 14:31 ` [PATCH 06/11] USB: OHCI: Properly handle ohci-exynos suspend Alan Stern
2013-10-03 14:51   ` Bartlomiej Zolnierkiewicz
2013-10-03 15:28   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2013-06-12 15:28 [PATCH 00/10] USB: OHCI:Properly handle ohci_suspend()routine in bus glue Manjunath Goudar
2013-07-22  9:32 ` [PATCH 00/11] " Manjunath Goudar
2013-07-22  9:32   ` [PATCH 06/11] USB: OHCI: Properly handle ohci-exynos suspend Manjunath Goudar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2706834.Eq1ry5ZFL1@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.