From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 30 Sep 2013 18:31:05 +0000 Subject: Re: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag Message-Id: <27072275.6rIbiFzHY2@avalon> List-Id: References: <1959578.PFsrHiTtYY@amdc1032> In-Reply-To: <1959578.PFsrHiTtYY@amdc1032> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park Acked-by: Laurent Pinchart > --- > v2: > - use __initdata as it is OK to do it > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 > --- a/arch/arm/mach-shmobile/board-ape6evm.c > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), > }; > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { > .buttons = gpio_buttons, > .nbuttons = ARRAY_SIZE(gpio_buttons), > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 30 Sep 2013 20:31:05 +0200 Subject: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag In-Reply-To: <1959578.PFsrHiTtYY@amdc1032> References: <1959578.PFsrHiTtYY@amdc1032> Message-ID: <27072275.6rIbiFzHY2@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park Acked-by: Laurent Pinchart > --- > v2: > - use __initdata as it is OK to do it > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 > --- a/arch/arm/mach-shmobile/board-ape6evm.c > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), > }; > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { > .buttons = gpio_buttons, > .nbuttons = ARRAY_SIZE(gpio_buttons), > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432Ab3I3Sa7 (ORCPT ); Mon, 30 Sep 2013 14:30:59 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:53647 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754691Ab3I3Sa6 (ORCPT ); Mon, 30 Sep 2013 14:30:58 -0400 From: Laurent Pinchart To: Bartlomiej Zolnierkiewicz Cc: Simon Horman , Magnus Damm , linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kyungmin Park Subject: Re: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag Date: Mon, 30 Sep 2013 20:31:05 +0200 Message-ID: <27072275.6rIbiFzHY2@avalon> User-Agent: KMail/4.10.5 (Linux/3.8.13-gentoo; KDE/4.10.5; x86_64; ; ) In-Reply-To: <1959578.PFsrHiTtYY@amdc1032> References: <1959578.PFsrHiTtYY@amdc1032> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park Acked-by: Laurent Pinchart > --- > v2: > - use __initdata as it is OK to do it > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 > --- a/arch/arm/mach-shmobile/board-ape6evm.c > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), > }; > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { > .buttons = gpio_buttons, > .nbuttons = ARRAY_SIZE(gpio_buttons), > }; -- Regards, Laurent Pinchart