diff for duplicates of <2710170.YbEgzp5Yxe@avalon> diff --git a/a/1.txt b/N1/1.txt index af32630..98721e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -239,7 +239,7 @@ an unsigned int. > + unsigned int i; > + > + for (i = 0; i < ARRAY_SIZE(ceu_fmt_list); i++, fmt++) -> + if (fmt->fourcc == fourcc) +> + if (fmt->fourcc = fourcc) > + return fmt; > + > + return NULL; @@ -354,14 +354,12 @@ I wonder why there's a need to disable and reenable interrupts here. > + return -EINVAL; > + } > + -> + phys_addr_top = -> + vb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, 0); +> + phys_addr_top > + vb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, 0); > + ceu_write(ceudev, CEU_CDAYR, phys_addr_top); > + > + /* Ignore CbCr plane in data sync mode */ > + if (ceu_is_fmt_planar(pix)) { -> + phys_addr_top = -> + vb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, +> + phys_addr_top > + vb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, > + 1); > + ceu_write(ceudev, CEU_CDACR, phys_addr_top); > + } @@ -720,7 +718,7 @@ subdev bind time). > + ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg); > + if (ret < 0 && ret != -ENOIOCTLCMD) > + return ret; -> + else if (ret == -ENOIOCTLCMD) +> + else if (ret = -ENOIOCTLCMD) > + return 0; > + > + common_flags = ceu_mbus_config_compatible(&cfg, common_flags); @@ -770,7 +768,7 @@ No need to assign a value to common_flags. > + ret = ceu_test_mbus_param(ceudev); > + if (ret < 0) > + return ret; -> + else if (ret == 0) +> + else if (ret = 0) > + common_flags = ceudev->sd->mbus_flags; > + else > + common_flags = ret; @@ -1405,7 +1403,7 @@ You can assign ceudev->base directly and remove the base local variable. > + if (num_sd < 0) { > + ret = num_sd; > + goto error_v4l2_unregister; -> + } else if (num_sd == 0) +> + } else if (num_sd = 0) > + return 0; You need braces around the second statement too. diff --git a/a/content_digest b/N1/content_digest index 59c0a63..87f03ad 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01510743363-25798-4-git-send-email-jacopo+renesas@jmondi.org\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver\0" - "Date\0Mon, 11 Dec 2017 18:15:23 +0200\0" + "Date\0Mon, 11 Dec 2017 16:15:23 +0000\0" "To\0Jacopo Mondi <jacopo+renesas@jmondi.org>\0" "Cc\0magnus.damm@gmail.com" geert@glider.be @@ -255,7 +255,7 @@ "> +\tunsigned int i;\n" "> +\n" "> +\tfor (i = 0; i < ARRAY_SIZE(ceu_fmt_list); i++, fmt++)\n" - "> +\t\tif (fmt->fourcc == fourcc)\n" + "> +\t\tif (fmt->fourcc = fourcc)\n" "> +\t\t\treturn fmt;\n" "> +\n" "> +\treturn NULL;\n" @@ -370,14 +370,12 @@ "> +\t\treturn -EINVAL;\n" "> +\t}\n" "> +\n" - "> +\tphys_addr_top =\n" - "> +\t\tvb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, 0);\n" + "> +\tphys_addr_top > +\t\tvb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf, 0);\n" "> +\tceu_write(ceudev, CEU_CDAYR, phys_addr_top);\n" "> +\n" "> +\t/* Ignore CbCr plane in data sync mode */\n" "> +\tif (ceu_is_fmt_planar(pix)) {\n" - "> +\t\tphys_addr_top =\n" - "> +\t\t\tvb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf,\n" + "> +\t\tphys_addr_top > +\t\t\tvb2_dma_contig_plane_dma_addr(&ceudev->active->vb2_buf,\n" "> +\t\t\t\t\t\t 1);\n" "> +\t\tceu_write(ceudev, CEU_CDACR, phys_addr_top);\n" "> +\t}\n" @@ -736,7 +734,7 @@ "> +\tret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);\n" "> +\tif (ret < 0 && ret != -ENOIOCTLCMD)\n" "> +\t\treturn ret;\n" - "> +\telse if (ret == -ENOIOCTLCMD)\n" + "> +\telse if (ret = -ENOIOCTLCMD)\n" "> +\t\treturn 0;\n" "> +\n" "> +\tcommon_flags = ceu_mbus_config_compatible(&cfg, common_flags);\n" @@ -786,7 +784,7 @@ "> +\tret = ceu_test_mbus_param(ceudev);\n" "> +\tif (ret < 0)\n" "> +\t\treturn ret;\n" - "> +\telse if (ret == 0)\n" + "> +\telse if (ret = 0)\n" "> +\t\tcommon_flags = ceudev->sd->mbus_flags;\n" "> +\telse\n" "> +\t\tcommon_flags = ret;\n" @@ -1421,7 +1419,7 @@ "> +\tif (num_sd < 0) {\n" "> +\t\tret = num_sd;\n" "> +\t\tgoto error_v4l2_unregister;\n" - "> +\t} else if (num_sd == 0)\n" + "> +\t} else if (num_sd = 0)\n" "> +\t\treturn 0;\n" "\n" "You need braces around the second statement too.\n" @@ -1445,4 +1443,4 @@ "\n" Laurent Pinchart -861328ced0c0b21eeb570356c188141ef8d421fc9a1ab51fe62dfb293b701b3e +d77c6463aa2dee39df09e461518f0f98b916259f2be8c626187f4ffea59749f5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.