From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: update bbdev library documentation Date: Sun, 22 Apr 2018 22:17:04 +0200 Message-ID: <2713250.YhKZBbbERd@xps> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, amr.mokhtar@intel.com To: KamilX Chalupnik Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BACB4F64 for ; Sun, 22 Apr 2018 22:17:06 +0200 (CEST) In-Reply-To: <20180404140602.9344-1-kamilx.chalupnik@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 04/04/2018 16:05, KamilX Chalupnik: > From: "Chalupnik, KamilX" The above line will appear as the author name in Git. Please make sure it is the same as the Signed-off-by line. Usually, we use FirstName LastName, without any comma. > Update the documentation describing Wireless Basband Device: > - device capabilities updated > - input/output data buffers description added > - details about implementation of turbo encode/decode > operation added > - images presenting CB/TB processing by turbo encoder/decoder > added > > Signed-off-by: KamilX Chalupnik Is KamilX your name? Or just Kamil? > doc/guides/prog_guide/bbdev.rst | 247 +++++++++++++++++++++++--- > doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 bytes > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 bytes > 3 files changed, 222 insertions(+), 25 deletions(-) > create mode 100644 doc/guides/prog_guide/img/turbo_tb_decode.png > create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png No, sorry, you cannot add binary file in this repository. It is an Open Source project, we provide sources. For figures, the SVG format is preferred. I'm sorry that your Intel colleagues did not warn you.